Remove default "public" visibility attribute#147
Open
antoniovazevedo wants to merge 1 commit intoInfinetyEs:masterfrom
Open
Remove default "public" visibility attribute#147antoniovazevedo wants to merge 1 commit intoInfinetyEs:masterfrom
antoniovazevedo wants to merge 1 commit intoInfinetyEs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the visibility of the files is hard coded as public.
The config on Laravel's filesystem disks already specifies a
visibilityattribute.Therefore, I think it would be best for this package to leave the visibility of the files up to the disk config.
The result is files are uploaded to the disk with the visibility specified on the disk config.
In the current version it is not possible to upload files with visibility set as "private", which is what I need in my use case.