Repository navigation
SecretScanner extra_patterns are added to the shared default patterns - #35
Merged
sergiobe-itx merged 2 commits intoNov 2, 2026
Merged
Conversation
Signed-off-by: Manuel Beardo Campo <210421738+Lostmanu@users.noreply.github.com>
Contribution License Agreement - Valid 🟢All commits contain valid signoff. As a confirmation, remember that you are agreeing to our Contribution License Agreement. |
sergiobe-itx
changed the title
Signed-off-by: Sergio Bugallo Enjamio <sergiobe@inditex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecretScannerappendedextra_patternsto the sharedDEFAULT_SECRET_PATTERNSlist, so they leaked into every defaultSecretScanner. It now copies the defaults first, asPiiScannerdoes. Two new tests intest_scanner.pycover a default scanner created before another one with extra patterns, and the same extra pattern passed to two scanners.Fixes #34
Checklist
git commit -S)Additional context
pytestinpackages/cerbia-core: 792 tests pass with the change. Without it, the two new tests fail and the other 790 pass.