Repository navigation
Handle directory paths and path assertions gracefully on windows - #23
Merged
sergiobe-itx merged 1 commit intoOct 13, 2026
Merged
Conversation
Contribution License Agreement - Valid 🟢All commits contain valid signoff. As a confirmation, remember that you are agreeing to our Contribution License Agreement. |
jmcaamanog
force-pushed
the
fix/cli-windows-directory-handling
branch
2 times, most recently
from
October 9, 2026 07:46
8018dd5 to
af8aee4
Compare
…ndows - Catch PermissionError on Windows when opening directories in load_config_from_yaml and report as directory path error - Strip table box-drawing characters when normalizing scan help output in tests to prevent line-wrapping assertion failures - Use json.loads to parse scan results in CLI tests to handle escaped Windows path separators properly Signed-off-by: jmcaamanog <jose.caamano@live.com>
jmcaamanog
force-pushed
the
fix/cli-windows-directory-handling
branch
from
October 9, 2026 07:53
af8aee4 to
561bd77
Compare
sergiobe-itx
approved these changes
Oct 13, 2026
sergiobe-itx
changed the title
Contributor
|
Thanks for the contribution! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
open()on a directory path raises aPermissionError(Errno 13, EACCES) instead of POSIX'sIsADirectoryError(Errno 21, EISDIR). Updatedload_config_from_yamlinpackages/cerbia-cli/src/cerbia/cli/config.pyto checkif path.is_dir()when catchingPermissionError, ensuring consistent and actionable error reporting across all operating systems.│) when normalizingscan --helpoutput inpackages/cerbia-cli/tests/unit/cerbia/cli/scan/test_command.pyto prevent brittle assertions caused by terminal column line wrapping.json.loadsintest_scan_uses_real_cli_text_and_file_loadersto handle escaped backslashes in Windows file paths reliably.Validation
pytest packages/cerbia-cli/tests/unit).ruff check&ruff format).