refactor: drop the last two any casts - #50
Merged
Merged
Conversation
setup.ts read the existing MCP server entries as Record<string, any> to reach `.env.BLOCKFROST_API_KEY`; the file already has a ServerConfig interface, and Partial<ServerConfig> types that access exactly. payment.ts cast the server to `any` when handing it to wrapWithSplitPayment, which takes the same McpServer type this file imports — the cast was not needed and tsc is happy without it. eslint is now clean with no warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a commit on the #48 branch that missed the merge by a few minutes — pushed just after #48 was merged, so it stayed behind. Re-applied on current main.
src/cli/setup.tsread the existing MCP server entries asRecord<string, any>to reach.env.BLOCKFROST_API_KEY. The file already defines aServerConfiginterface, andPartial<ServerConfig>types that access exactly.src/payment.tscast the server toanywhen handing it towrapWithSplitPayment, which takes the sameMcpServertype the file already imports. The cast was not needed; tsc is happy without it.eslint srcreports no warnings after this, where it previously reported these two. Typecheck and tests clean.