Repository navigation
fix(tui): preserve streamed markdown source and answer continuity - #394
Closed
dallenpyrah wants to merge 1 commit into
Closed
dallenpyrah wants to merge 1 commit into
dallenpyrah wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render reasoning through the same Markdown adapter as assistant answers, and preserve the original assistant source instead of trimming it before rendering.
A real OpenTUI regression exercises one-character, seven-character, and whole-string fragments, hard breaks, inline/fenced code, identical final rendered frames, offline working-to-idle continuity, and Home/End input. The reasoning assertion failed before the fix because the renderer displayed literal Markdown.
Part of #382. This PR remains draft until #378 supplies hosted preview/committed response identities and we verify attempt fencing, stale frames, reconnect, delayed commits, and atomic durable handoff. Offline status continuity is not evidence of hosted handoff correctness. No transport or projection contract is introduced.
Validated with Bun 1.4.0: three TUI tests, five presenter/client unit tests, TUI v2 typecheck/lint, focused formatting, and
git diff --checkpassed.Actual OpenTUI rendering: