Fix Overture release id parsing and pin affine<3 (main fails since August) - #507
Open
Zhonghao Zhang (Zhonghao1995) wants to merge 2 commits into
Open
Zhonghao Zhang (Zhonghao1995) wants to merge 2 commits into
Zhonghao Zhang (Zhonghao1995) wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 87.34% 87.28% -0.06%
==========================================
Files 23 23
Lines 2355 2360 +5
Branches 302 303 +1
==========================================
+ Hits 2057 2060 +3
- Misses 206 207 +1
- Partials 92 93 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
barneydobson
approved these changes
Sep 21, 2026
Collaborator
There was a problem hiding this comment.
Happy with that Zhonghao Zhang (@Zhonghao1995) go ahead and merge! and thanks for your contributions ✨
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #505: the same two commits, now on a branch in this repository so that CI has access to the Codecov token and does not need approval for each run.
Closes #502 and #503.
Problem observed
On a fresh
pip install -e .ofmain(f0c18be) on 2026-09-04, macOS 26.6.2, Python 3.11.15, every run failed twice over:_get_latest_s3_urltakesPath(href).parentof the newest child link in the Overture STAC catalog; those hrefs are absolute URLs now, so the release id came out ashttps:/stac.overturemaps.org/2026-08-19.0and was then cached in.cache/overture_release.jsonfor 72 hours.clip_to_catchments:affine3.0 (released 2026-08-08) turnedAffinefrom a namedtuple into a plain class, and the@njitfunctionpyflwdir.dem.slopethatgeospatial_utilitiescalls with the raster transform can no longer type it.pyflwdir 0.5.12has not adapted yet.Both come from upstream changes in August, so
maincurrently fails the notebook runs in CI as well; the last green run onmainpredates them. The two fixes are in one PR because the notebooks need both to get through: with only one of them CI fails on the other error (that is what #505 and #506 showed separately).Changes
\d{4}-\d{2}-\d{2}\.\d+) from the href instead of taking the parent path; the catalog ordering logic is unchanged. A cached entry whosereleaseis not a well-formed id is ignored, so working directories that already hold the malformed cache recover on their own. Two mocked tests intests/test_prepare_data.py, no network access.affine<3inpyproject.toml. The alternative is to pass a plain tuple topyflwdir.dem.slopeingeospatial_utilities(the numba kernel only indexestransform[0],[4]and[5]); happy to switch to that if you prefer a code change over a pin.Checks
pytest tests/test_prepare_data.py -k s3_url(2 passed), the repository's pre-commit hooks, and with both changes the documentation's Andorra bounding box builds end to end again withaffine 2.4.0.