Pin affine<3 until pyflwdir supports affine 3 - #506
Closed
Zhonghao Zhang (Zhonghao1995) wants to merge 1 commit into
Closed
Zhonghao Zhang (Zhonghao1995) wants to merge 1 commit into
Zhonghao Zhang (Zhonghao1995) wants to merge 1 commit into
Conversation
Collaborator
Author
|
Folded into #505: the notebook runs in CI need this pin and the Overture fix at the same time, so keeping them in one PR is the only way to get a green run. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #503.
Problem observed
On a fresh
pip install -e .ofmain(f0c18be) on 2026-09-04, macOS 26.6.2, Python 3.11.15, the resolver picksaffine 3.0.1, and every run then fails duringclip_to_catchments:affine3.0 turnedAffinefrom a namedtuple into a plain class.pyflwdir.dem.slopeis@njit-compiled and receives the raster transform fromgeospatial_utilities; numba could type the old tuple and cannot type the new class.pyflwdir 0.5.12, the latest release, has not adapted yet. Installed alongside:pyflwdir 0.5.12,numba 0.67.0,rasterio 1.4.4,numpy 2.4.6.Change
Pin
affine<3inpyproject.toml. Withaffine 2.4.0the same environment builds the documentation's Andorra bounding box end to end (together with #502).The alternative is to pass a plain tuple to
pyflwdir.dem.slopeingeospatial_utilities(the numba kernel only indexestransform[0],[4]and[5]); happy to switch to that if you prefer a code change over a pin.