Skip to content

fix(ci): pre-commit — PR #469 - #488

Closed
barneydobson wants to merge 2 commits into
mainfrom
pr-maintainer/pr-469-fix-1777748318
Closed

fix(ci): pre-commit — PR #469#488
barneydobson wants to merge 2 commits into
mainfrom
pr-maintainer/pr-469-fix-1777748318

Conversation

@barneydobson

Copy link
Copy Markdown
Collaborator

Automated fix targeting ImperialCollegeLondon/SWMManywhere#469.

What failed (classification)

  • Kind: pre_commit (pre-commit)
  • Notes: pre-commit-style log; no hook id lines parsed

Reproduce locally

  • Strategy: pre-commit all hooks (no hook ids parsed)

Command used for the final green verify:

pixi run --manifest-path /home/barney/Documents/GitHub/SWMManywhere/pixi.toml pre-commit run --all-files

Failing CI run

Excerpt from downloaded Actions logs (may be truncated):

test session starts ==============================
2026-05-01T18:36:55.4926326Z platform linux -- Python 3.10.20, pytest-9.0.3, pluggy-1.6.0 -- /opt/hostedtoolcache/Python/3.10.20/x64/bin/python
2026-05-01T18:36:55.4927074Z cachedir: .pytest_cache
2026-05-01T18:36:55.4927346Z rootdir: /home/runner/work/SWMManywhere/SWMManywhere
2026-05-01T18:36:55.4927648Z configfile: pyproject.toml
2026-05-01T18:36:55.4927879Z plugins: cov-7.1.0, mypy-1.0.1, mock-3.15.1
2026-05-01T18:51:43.0075650Z collecting ... collected 110 items / 8 deselected / 102 selected
2026-05-01T18:51:43.0076089Z 
2026-05-01T18:51:43.0143222Z src/swmmanywhere/geospatial_utilities.py::swmmanywhere.geospatial_utilities.get_transformer PASSED [  0%]
2026-05-01T18:51:43.1064559Z src/swmmanywhere/geospatial_utilities.py::swmmanywhere.geospatial_utilities.get_utm_epsg PASSED [  1%]
2026-05-01T18:51:43.1152420Z src/swmmanywhere/post_processing.py::swmmanywhere.post_processing.explode_polygon PASSED [  2%]
2026-05-01T18:51:43.1896170Z src/swmmanywhere/post_processing.py::swmmanywhere.post_processing.format_to_swmm_dict PASSED [  3%]
2026-05-01T18:52:38.7531688Z tests/test_cli.py::test_swmmanywhere_cli PASSED                          [  4%]
2026-05-01T18:52:38.7549744Z tests/test_geospatial_utilities.py::test_interp_with_nans PASSED         [  5%]
2026-05-01T18:52:38.7589297Z tests/test_geospatial_utilities.py::test_interpolate_points_on_raster PASSED [  6%]
2026-05-01T18:52:38.9305603Z tests/test_geospatial_utilities.py::test_get_utm PASSED                  [  7%]
2026-05-01T18:52:38.9568114Z tests/test_geospatial_utilities.py::test_reproject_raster PASSED         [  8%]
2026-05-01T18:52:38.9585647Z tests/test_geospatial_utilities.py::test_get_transformer PASSED          [  9%]
2026-05-01T18:52:38.9609031Z tests/test_geospatial_utilities.py::test_reproject_graph PASSED          [ 10%]
2026-05-01T18:52:38.9626378Z tests/test_geospatial_utilities.py::test_nearest_node_buffer PASSED      [ 11%]
2026-05-01T18:52:38.9701097Z tests/test_geospatial_utilities.py::test_burn_shape_in_raster PASSED     [ 12%]
2026-05-01T18:52:48.2801202Z tests/test_geospatial_utilities.py::test_derive_subcatchments[True-pyflwdir-2498-0.1187-28.202] PASSED [ 13%]
2026-05-01T18:52:49.1620468Z tests/test_geospatial_utilities.py::test_derive_subcatchments[True-whitebox-2998-0.1102-30.894] PASSED [ 14%]
2026-05-01T18:52:49.1938595Z tests/test_geospatial_utilities.py::test_derive_subcatchments[False-pyflwdir-2498-0.1187-28.202] PASSED [ 15%]
2026-05-01T18:52:50.0404831Z tests/test_geospatial_utilities.py::test_derive_subcatchments[False-whitebox-2998-0.1102-30.894] PASSED [ 16%]
2026-05-01T18:52:50.2705204Z tests/test_geospatial_utilities.py::test_derive_rc PASSED                [ 17%]
2026-05-01T18:52:50.2718213Z tests/test_geospatial_utilities.py::test_calculate_angle PASSED          [ 18%]
2026-05-01T18:52:50.2834109Z tests/test_geospatial_utilities.py::test_remove_intersections PASSED     [ 19%]
2026-05-01T18:52:50.3167872Z tests/test_geospatial_utilities.py::test_graph_to_file[.geojson] PASSED  [ 20%]
2026-05-01T18:52:50.4073699Z tests/test_geospatial_utilities.py::test_graph_to_file[.geoparquet] PASSED [ 21%]
2026-05-01T18:52:50.4110133Z tests/test_geospatial_utilities.py::test_merge_points PASSED             [ 22%]
2026-05-01T18:52:50.4268313Z tests/test_graph_utilities.py::test_save_load PASSED                     [ 23%]
2026-05-01T18:52:50.4299937Z tests/test_graph_utilities.py::test_assign_id PASSED                     [ 24%]
2026-05-01T18:52:50.4359164Z tests/test_graph_utilities.py::test_double_directed PASSED               [ 25%]
2026-05-01T18:52:50.4766453Z tests/test_graph_utilities.py::test_calculate_streetcover PASSED         [ 26%]
2026-05-01T18:52:50.4978219Z tests/test_graph_utilities.py::test_split_long_edges PASSED              [ 27%]
2026-05-01T18:52:51.7597470Z tests/test_graph_utilities.py::test_derive_subcatchments PASSED          [ 28%]
2026-05-01T18:52:51.7719432Z tests/test_graph_utilities.py::test_set_elevation_and_slope PASSED       [ 29%]
2026-05-01T18:52:51.7765136Z tests/test_graph_utilities.py::test_chahinian_angle PASSED               [ 30%]
2026-05-01T18:52:51.7814870Z tests/test_graph_utilities.py::test_calculate_weights PASSED             [ 31%]
2026-05-01T18:52:51.7862999Z tests/test_graph_utilities.py::test_calculate_weights_novar PASSED       [ 32%]
2026-05-01T18:52:51.8122644Z tests/test_graph_utilities.py::test_identify_outfalls_no_river PASSED    [ 33%
... [session excerpt truncated to 4500 chars]

Local verify (after agent edits)

Final successful run of the same repro command (truncated if long):

check for merge conflicts.....................................................Passed
debug statements (python).....................................................Passed
ruff (legacy alias)...........................................................Passed
ruff format...................................................................Passed
mypy..........................................................................Passed
markdownlint..................................................................Passed
Check common misspellings in text files with codespell........................Passed
Apply a consistent format to pyproject.toml...................................Passed
Modernizing Python codebases using Refurb.....................................Passed

Mechanical CI context

  • Local reproduction command: pixi run --manifest-path /home/barney/Documents/GitHub/SWMManywhere/pixi.toml pre-commit run --all-files
  • CI command inferred from logs: pytest
  • Suggested sanity command(s): pixi run --manifest-path /home/barney/Documents/GitHub/SWMManywhere/pixi.toml pytest --lf -q /home/barney/.pr-maintainer/worktrees/ImperialCollegeLondon_SWMManywhere-pr469-1777748318/tests
  • Failure mode signals: normal_assertion
  • Confidence: high
  • Mechanical risk notes:
    • Local reproduction command differs from the apparent CI command.

Run metadata

  • Agent: provider deepinfra, model Qwen/Qwen3-Next-80B-A3B-Instruct
  • Succeeded on maintainer round: 1 (of automated rounds)

Session debug files under maintainer_state/ are omitted from this branch by default; they are summarised above when relevant.

dependabot Bot and others added 2 commits April 29, 2026 18:10
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...v8)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@barneydobson
barneydobson deleted the pr-maintainer/pr-469-fix-1777748318 branch May 5, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant