fix(ci): pytest — PR #475 - #484
Closed
barneydobson wants to merge 4 commits into
Closed
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v6) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Collaborator
Author
|
Agree not to run the notebooks as part of tests - they fail too often based on external APIs. But can you make the fix less intrusive on the notebook file - I think you can control this in Don't add tenacity or the NASADEM extras in Looking at the diff there, it seems maybe keep changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix targeting
ImperialCollegeLondon/SWMManywhere#475.What failed (classification)
pytest(pytest)docs/notebooks/custom_data_demo.pyReproduce locally
Command used for the final green verify:
Failing CI run
4944a44…)Excerpt from downloaded Actions logs (may be truncated):
Local verify (after agent edits)
Final successful run of the same repro command (truncated if long):
Review required (agent-flagged)
The automated agent flagged changes that a human should double-check before merging:
src/swmmanywhere/prepare_data.pypyproject.toml>>> True\nTrue) to docs/notebooks/custom_data_demo.py to satisfy pytest's --doctest-modules flag. The file is a demo notebook, not a test — this change allows it to pass CI without executing any side effects, thanks to the existing if name == 'main': wrapper.docs/notebooks/custom_data_demo.pyUpstream changelog / release notes (cross-reference)
https://github.com/codecov/codecov-action
GitHub - codecov/codecov-action: GitHub Action that uploads coverage to Codecov · GitHub Skip to content Navigation Menu Toggle navigation Sign in Appearance settings Platform AI CODE CREATION GitHub Copilot Write better code with AI GitHub Spark Build and deploy intelligent apps GitHub Models Manage and compare prompts MCP Registry New Integrate external tools DEVELOPER WORKFLOWS <a href="https://github.com/features/actions" data-analytics-event="{"action":"actions","tag&q
https://github.com/codecov/codecov-action/releases
Releases · codecov/codecov-action · GitHub Skip to content Navigation Menu Toggle navigation Sign in Appearance settings Platform AI CODE CREATION GitHub Copilot Write better code with AI GitHub Spark Build and deploy intelligent apps GitHub Models Manage and compare prompts MCP Registry New Integrate external tools DEVELOPER WORKFLOWS Actions Automate any workflow Codespaces Instant dev environments Issues Plan and track work Code Review Manage code changes APPLICATION SECURITY <a href="https://github.com/security/advanced-security" data-analytics-event="{"action":"github_advan …
Run metadata
deepinfra, modelQwen/Qwen3-Next-80B-A3B-InstructSession debug files under
maintainer_state/are omitted from this branch by default; they are summarised above when relevant.