Skip to content

fix(ci): pre-commit — PR #469 - #481

Closed
barneydobson wants to merge 2 commits into
mainfrom
pr-maintainer/pr-469-fix-1776769021
Closed

barneydobson wants to merge 2 commits into
mainfrom
pr-maintainer/pr-469-fix-1776769021

Conversation

@barneydobson

Copy link
Copy Markdown
Collaborator

Automated fix targeting ImperialCollegeLondon/SWMManywhere#469.

What failed (classification)

  • Kind: pre_commit (pre-commit)
  • Notes: pre-commit-style log; no hook id lines parsed

Reproduce locally

  • Strategy: pre-commit all hooks (no hook ids parsed)

Command used for the final green verify:

pip install -e ".[dev]" && pre-commit run --all-files --show-diff-on-failure

Failing CI run

Excerpt from downloaded Actions logs (may be truncated):

test session starts ==============================
2026-03-31T08:51:57.8062608Z platform linux -- Python 3.10.20, pytest-9.0.2, pluggy-1.6.0 -- /opt/hostedtoolcache/Python/3.10.20/x64/bin/python
2026-03-31T08:51:57.8063537Z cachedir: .pytest_cache
2026-03-31T08:51:57.8064361Z rootdir: /home/runner/work/SWMManywhere/SWMManywhere
2026-03-31T08:51:57.8064934Z configfile: pyproject.toml
2026-03-31T08:51:57.8065453Z plugins: cov-7.1.0, mock-3.15.1, mypy-1.0.1
2026-03-31T09:07:14.1925316Z collecting ... collected 110 items / 8 deselected / 102 selected
2026-03-31T09:07:14.1925770Z 
2026-03-31T09:07:14.1987007Z src/swmmanywhere/geospatial_utilities.py::swmmanywhere.geospatial_utilities.get_transformer PASSED [  0%]
2026-03-31T09:07:14.2926173Z src/swmmanywhere/geospatial_utilities.py::swmmanywhere.geospatial_utilities.get_utm_epsg PASSED [  1%]
2026-03-31T09:07:14.3014452Z src/swmmanywhere/post_processing.py::swmmanywhere.post_processing.explode_polygon PASSED [  2%]
2026-03-31T09:07:14.3798404Z src/swmmanywhere/post_processing.py::swmmanywhere.post_processing.format_to_swmm_dict PASSED [  3%]
2026-03-31T09:08:09.3469112Z tests/test_cli.py::test_swmmanywhere_cli PASSED                          [  4%]
2026-03-31T09:08:09.3488070Z tests/test_geospatial_utilities.py::test_interp_with_nans PASSED         [  5%]
2026-03-31T09:08:09.3528239Z tests/test_geospatial_utilities.py::test_interpolate_points_on_raster PASSED [  6%]
2026-03-31T09:08:09.5347163Z tests/test_geospatial_utilities.py::test_get_utm PASSED                  [  7%]
2026-03-31T09:08:09.5612064Z tests/test_geospatial_utilities.py::test_reproject_raster PASSED         [  8%]
2026-03-31T09:08:09.5629066Z tests/test_geospatial_utilities.py::test_get_transformer PASSED          [  9%]
2026-03-31T09:08:09.5649670Z tests/test_geospatial_utilities.py::test_reproject_graph PASSED          [ 10%]
2026-03-31T09:08:09.5667476Z tests/test_geospatial_utilities.py::test_nearest_node_buffer PASSED      [ 11%]
2026-03-31T09:08:09.5738269Z tests/test_geospatial_utilities.py::test_burn_shape_in_raster PASSED     [ 12%]
2026-03-31T09:08:18.6161338Z tests/test_geospatial_utilities.py::test_derive_subcatchments[True-pyflwdir-2498-0.1187-28.202] PASSED [ 13%]
2026-03-31T09:08:19.4428576Z tests/test_geospatial_utilities.py::test_derive_subcatchments[True-whitebox-2998-0.1102-30.894] PASSED [ 14%]
2026-03-31T09:08:19.4757058Z tests/test_geospatial_utilities.py::test_derive_subcatchments[False-pyflwdir-2498-0.1187-28.202] PASSED [ 15%]
2026-03-31T09:08:20.2662261Z tests/test_geospatial_utilities.py::test_derive_subcatchments[False-whitebox-2998-0.1102-30.894] PASSED [ 16%]
2026-03-31T09:08:20.5022720Z tests/test_geospatial_utilities.py::test_derive_rc PASSED                [ 17%]
2026-03-31T09:08:20.5035202Z tests/test_geospatial_utilities.py::test_calculate_angle PASSED          [ 18%]
2026-03-31T09:08:20.5159173Z tests/test_geospatial_utilities.py::test_remove_intersections PASSED     [ 19%]
2026-03-31T09:08:20.5482737Z tests/test_geospatial_utilities.py::test_graph_to_file[.geojson] PASSED  [ 20%]
2026-03-31T09:08:20.6430520Z tests/test_geospatial_utilities.py::test_graph_to_file[.geoparquet] PASSED [ 21%]
2026-03-31T09:08:20.6467038Z tests/test_geospatial_utilities.py::test_merge_points PASSED             [ 22%]
2026-03-31T09:08:20.6626659Z tests/test_graph_utilities.py::test_save_load PASSED                     [ 23%]
2026-03-31T09:08:20.6659247Z tests/test_graph_utilities.py::test_assign_id PASSED                     [ 24%]
2026-03-31T09:08:20.6720564Z tests/test_graph_utilities.py::test_double_directed PASSED               [ 25%]
2026-03-31T09:08:20.7159346Z tests/test_graph_utilities.py::test_calculate_streetcover PASSED         [ 26%]
2026-03-31T09:08:20.7395455Z tests/test_graph_utilities.py::test_split_long_edges PASSED              [ 27%]
2026-03-31T09:08:21.9851689Z tests/test_graph_utilities.py::test_derive_subcatchments PASSED          [ 28%]
2026-03-31T09:08:21.9976105Z tests/test_graph_utilities.py::test_set_elevation_and_slope PASSED       [ 29%]
2026-03-31T09:08:22.0019800Z tests/test_graph_utilities.py::test_chahinian_angle PASSED               [ 30%]
2026-03-31T09:08:22.0068353Z tests/test_graph_utilities.py::test_calculate_weights PASSED             [ 31%]
2026-03-31T09:08:22.0114567Z tests/test_graph_utilities.py::test_calculate_weights_novar PASSED       [ 32%]
2026-03-31T09:08:22.0380750Z tests/test_graph_utilities.py::test_identify_outfalls_no_river PASSED    [ 33%
... [session excerpt truncated to 4500 chars]

Local verify (after agent edits)

Final successful run of the same repro command (truncated if long):

t/lib/python3.12/site-packages (from pyswmm->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (0.14)
Requirement already satisfied: aenum>=3.1.11 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from pyswmm->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (3.1.11)
Requirement already satisfied: iniconfig>=1.0.1 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from pytest->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (2.3.0)
Requirement already satisfied: pluggy<2,>=1.5 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from pytest->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (1.6.0)
Requirement already satisfied: pygments>=2.7.2 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from pytest->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (2.20.0)
Requirement already satisfied: coverage>=7.10.6 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from coverage[toml]>=7.10.6->pytest-cov->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (7.10.7)
Requirement already satisfied: cligj>=0.5 in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from rasterio->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (0.7.2)
Requirement already satisfied: click-plugins in /home/barney/Documents/GitHub/pr-maintainer/.pixi/envs/default/lib/python3.12/site-packages (from rasterio->swmmanywhere==0.2.2.dev9+g4a1140d48.d20260421) (1.1.1)
Building wheels for collected packages: swmmanywhere
  Building editable for swmmanywhere (pyproject.toml): started
  Building editable for swmmanywhere (pyproject.toml): finished with status 'done'
  Created wheel for swmmanywhere: filename=swmmanywhere-0.2.2.dev9+g4a1140d48.d20260421-py3-none-any.whl size=4625 sha256=fb6d6949e5e1a20b8bb70fffe11df9ebbd537f2b4f26104b3962aeea2171eeb3
  Stored in directory: /tmp/pip-ephem-wheel-cache-p_1xbr83/wheels/9e/cb/f4/9552733197344f71ae29b181eacc89a1253ccd2b6f93a9aa5d
Successfully built swmmanywhere
Installing collected packages: swmmanywhere
  Attempting uninstall: swmmanywhere
    Found existing installation: swmmanywhere 0.2.2.dev9+g4a1140d48.d20260421
    Uninstalling swmmanywhere-0.2.2.dev9+g4a1140d48.d20260421:
      Successfully uninstalled swmmanywhere-0.2.2.dev9+g4a1140d48.d20260421
Successfully installed swmmanywhere-0.2.2.dev9+g4a1140d48.d20260421
check for merge conflicts.....................................................Passed
debug statements (python).....................................................Passed
ruff (legacy alias)...........................................................Passed
ruff format...................................................................Passed
mypy..........................................................................Passed
markdownlint..................................................................Passed
Check common misspellings in text files with codespell........................Passed
Apply a consistent format to pyproject.toml...................................Passed

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
ukswmm 0.1.0 requires swmmanywhere<0.2.0,>=0.1.16, but you have swmmanywhere 0.2.2.dev9+g4a1140d48.d20260421 which is incompatible.

Run metadata

  • Agent: provider deepinfra, model Qwen/Qwen3-Next-80B-A3B-Instruct
  • Succeeded on maintainer round: 1 (of automated rounds)

Session debug files under maintainer_state/ are omitted from this branch by default; they are summarised above when relevant.

dependabot Bot and others added 2 commits March 30, 2026 10:30
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...v8)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@barneydobson
barneydobson deleted the pr-maintainer/pr-469-fix-1776769021 branch April 21, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant