KeylessAgent: full agent stack — parser hardening, browser reliability, WPF UI, snapshot budgets, NuGet publishing

DOCS-TODO.md

@@ -0,0 +1,19 @@
+# DOCS-TODO
+
+- P0 copy-button path: MessageCopyButton selectors replaced (aria-label/title "copy" with the case-insensitive `i` flag, `.ds-message` scoping) plus a GetByRole accessibility fallback (direct + after hover) in ClickNewestCopyControlAsync; WaitForMessageCopyButtonAsync logs the tried selectors and the `keyless doctor --capture` hint when nothing matches — selectors are UNVERIFIED until run against the live chat; verify with `keyless doctor --capture` (MessageCopyButton must be MATCHED) and confirm the next turn log shows Source "Copy".
+- P1 parser repair: RepairKnownCorruptions splits close-marker+@@-command and @@end+@@-command chains onto separate lines (fixpoint, up to 3 passes); the legacy ParseBadMarker rejection test in AgentScriptParserTests was replaced by the repaired-outcome test — no docs change needed, but the AgentScript spec's format-error list should mention the auto-repair.
+- P2 lenient shapes: "@@say hello" (argument becomes MSG), one outer code fence stripped from CONTENT, say-only replies no longer rejected (KA_PARSE_SAY_ONLY is now unused by the validator but stays documented in the catalog) — document the accepted one-line shapes in docs/agentscript-spec.md.
+- P4 stalls: defaults ReplyTimeoutSeconds 180, SendConfirmSeconds 8, UploadWaitSeconds 15 (docs/configuration.md updated); generation waits in ResetComposerAsync/WaitForGenerationAsync capped at 10 s; IsSendEnabledAsync skips the paperclip button in one round trip; StopIndicator selectors replaced (div:has(textarea) scoping — UNVERIFIED until live chat).
+- P5 minimize: no URL in the Chrome launch arguments (Chrome 136+ ignores --start-minimized with a URL); MinimizeWindowAsync falls back to Win32 ShowWindow through the launched process id — document the two-step minimize in docs/browser-automation.md.
+- A1 selector-probe timeouts: EvaluateAsync hard-capped at 1.5 s; IsSendEnabledAsync skips absent selectors via an instant CountAsync (no element resolution, no EvaluateAsync) while keeping the paperclip skip and the null=undetectable contract; SetInputFiles 5 s, accessibility-hover 2 s, page.SetDefaultTimeout(5000) on every connection path as the safety net; IsSendEnabledAsync/ResetComposerAsync log a warning above 2 s (with the slowest selector index). The 60/120/180 s send/upload multiples should be gone — UNVERIFIED until a live run's --timing table shows no phase at or above 30 s.
+- A2 copy-button cost: first copy wait capped at 3 s; a per-session circuit breaker (_copyButtonBroken) skips the whole copy path after the first miss (origin 'copy disabled after the first miss this session'), reset naturally by a new session/run or a doctor --capture re-check; Browser.ReplySource=Dom still short-circuits with zero waits. Copy behavior UNVERIFIED until run against the live chat (the selector may still not match — the circuit breaker only caps the cost).
+- B minimize persistence: Target.createTarget now sends background=true (Chrome activated the new tab and restored the minimized window); the minimize runs IMMEDIATELY after OpenChatTabAsync (when WindowMode=Minimized and MinimizeAfterLogin) and again after login; CDP verifies via Browser.getWindowBounds read-back with a normal->minimized recovery, up to 3 attempts; the Win32 fallback was made real (ChromeWindowMinimizer: EnumWindows over Chrome_WidgetWin_1 windows owned by our chrome.exe processes — the launched PID's descendant tree or the --user-data-dir/--remote-debugging-port command-line match — then ShowWindow(SW_MINIMIZE)). FocusTabAsync/BringToFront stays login-only. UNVERIFIED until run on the live chat (window must minimize within a few seconds and STAY minimized during sends).
+- Truncated replies under minimize: Chrome launch gains --disable-features=CalculateNativeWinOcclusion,IntensiveWakeUpThrottling (Windows 11 throttles minimized windows at the feature level even with the classic flags), --disable-ipc-flooding-protection, --disable-hang-monitor — the window still minimizes, the renderer keeps streaming. WaitForReplyAsync rejects an AgentScript reply without a trailing @@eof (keeps polling silently, no correction message), logs 'Truncated reply detected (attempt N)' + a 'reply-truncated' turn event (FocusTriggered:false) per detection, and fails with KA_REPLY_TRUNCATED at the 20th detection with a hint to enable Browser.AutoFocusOnTruncation or WindowMode:Offscreen — only when AutoFocusOnTruncation=true does the window focus ONCE at the fifth detection (opt-in; default path never un-minimizes, Chrome stays minimized for the whole turn; the CLI confirmation prompt rings a terminal bell instead of raising a window). UNVERIFIED until a live run: fresh-workspace turn must end with Reply ending '@@eof', no 'Block newfile opened on line 1 is never closed' correction, and a manual mid-turn minimize must still produce a complete reply.
+- Chrome window show/hide: IChromeWindowController (ChromeWindowController.cs) moves the window by pure CDP setWindowBounds (show: normal @100,100 1280x900 + Target.activateTarget; hide: normal @-32000,-32000; optional --peek returns offscreen after N seconds) — 'keyless show/hide <workspace>', a Show Chrome button on the doctor page, and 'keyless chrome' now show the window after connecting. The login flow shows the window instead of BringToFront (FocusTabAsync remains only as the IChatPage contract, unused by the provider). UNVERIFIED until live: show/hide during a running turn must not disturb send-attempt timing, and the Offscreen login flow must be visible.
+- True-minimize root cause (turn-16): WindowMode default was still 'Minimized' and the MinimizeAfterLogin path sent CDP windowState:'minimized', which Chrome throttles regardless of startup position — the stream then truncated 20x. Now: WindowMode default 'Offscreen'; 'Minimized' is backward-compatible and ALSO means offscreen (launch flags --window-position=-32000,-32000 --window-size=1280,900); HideWindowAsync (renamed from MinimizeWindowAsync) moves the window offscreen with windowState:'normal' and verifies via getWindowBounds read-back (left/top -32000), and the Win32 fallback uses SW_HIDE instead of SW_MINIMIZE. Doctor page has Start/Show/Hide Chrome buttons. UNVERIFIED until live: zero reply-truncated on a full turn, taskbar click produces nothing while offscreen, show at (100,100) 1280x900 not fullscreen.
+- Offscreen STILL throttles (turn-17: 20 truncations with the occlusion flag present; turn-18: visible window OK, hidden -> truncating again): Chrome treats fully offscreen positions as occluded regardless of --disable-features=CalculateNativeWinOcclusion. Fix: WindowMode default 'TinyCorner' (80x80 square, bottom-right of the REAL primary screen bounds via GetSystemMetrics, never hardcoded); new modes TinyCorner/EdgePeek (10x10 sliver, may still be throttled); every hide path (MinimizeWindowAsync successor, keyless hide, peek return) now moves to the same tiny corner instead of -32000; the launch command line is logged and emitted as a 'chrome-launched' turn event; 'keyless diagnostics chrome' prints the running Chrome's command line (Get-CimInstance) with a flag verdict. UNVERIFIED until live: TinyCorner/EdgePeek truncation counts (expected zero / near-zero), the visible 80x80 square during a turn, and whether EdgePeek's 10x10 passes Chrome's occlusion heuristic.
+- selectors.json versioning: CatalogVersion 2 in the embedded default + MergeAsync in SelectorsCatalog - a workspace file with an older/missing version is backed up (selectors.json.v<N>.bak) and merged: keys whose value matches ANY version ever shipped (ShippedValues table generated from git history; MessageCopyButton/StopIndicator/SendButton/DeepThinkToggle/SearchToggle/MessageItems) are refreshed to the current embedded values, genuine customizations and workspace-only keys survive, missing keys added; keyless selectors refresh <workspace> forces the merge; the copy-button miss warning points at it. UNVERIFIED until live: a real turn in an OLD workspace must show reply-source Source: Copy (the circuit breaker resets per session).
+- Truncation budget is WALL-CLOCK now: the old fixed 20-attempt count burned out in ~2-4s (detections ran back-to-back with no poll delay) while a stream that resumed after ~8s was still killed. New Browser.TruncationBudgetSeconds (default 20): the wait fails with KA_REPLY_TRUNCATED only when the time since the FIRST truncation detection exceeds it; detections are spaced by the normal poll delay (no busy-loop); the reply-truncated event carries ElapsedSeconds; AutoFocusOnTruncation fires at 25% of the budget instead of attempt 5. UNVERIFIED until live: an 8-10s slow stream must now complete instead of failing, and ElapsedSeconds must grow in step with real time in turn-N.jsonl.
+- DPI + launch-geometry diagnostics: a live chrome-launched log showed the RAW screen size (1840,1000 on 1920x1080) despite the SPI_GETWORKAREA fix - the process was not DPI-aware, so the screen APIs returned OS-virtualized values at non-100% scale. The CLI now embeds an app.manifest with dpiAwareness=PerMonitorV2 (ApplicationManifest in the csproj; verified embedded in the exe) and the WPF csproj sets ApplicationHighDpiMode=PerMonitorV2. Chrome launches now log raw screen vs work area side by side (plus RawScreenSize/WorkAreaSize fields in the chrome-launched turn event), and after the launch attach the connector locates the real HWND (FindOurChromeWindows, polled up to 3s), GetWindowRects it, logs actual-vs-requested (8px tolerance, MISMATCH warning on drift, chrome-window-bounds turn event). UNVERIFIED until live on the test machine: Raw/WorkArea differ by the taskbar height, --window-position uses work-area coordinates, actual GetWindowRect matches within pixels, and the 80x80 square is visibly on the desktop - note the machine resolution + scale factor first.
+- Chrome CLOSE path: IChromeWindowController.CloseAsync (options, allowAttached=false) - graceful CDP Browser.close (whole browser, profile flushed), the debug port polled ~3s to confirm, then a tree-kill fallback (Process.Kill(entireProcessTree)) of every chrome.exe whose command line carries OUR profile dir; a Chrome matched only by our port (user-launched, no profile) is REFUSED unless allowAttached - same ownership rule as AttachedToRunningChrome. Ownership matches RUNNING command lines (ChromeWindowMover.GetChromeProcessInfos), so it works after an app restart without a session PID. WPF: Close Chrome button (4th command, cross-disabling) + App.OnExit always-on safety net (4s bounded, distinct from CloseChromeOnExit which still only gates per-turn session disposal). UNVERIFIED until live: start-via-app -> normal app exit leaves no chrome.exe for the profile; Close Chrome button then Start Chrome relaunches cleanly; a manually-attached Chrome is untouched in both cases.
+- Snapshot size budget: Snapshot.Mode defaults to TreeAndChanged (Full still supported); a new total ceiling MaxTotalAttachmentChars (400k chars) caps EVERYTHING attached to one turn - when exceeded the tree stays complete, the dump keeps only request-referenced files, and everything else becomes per-folder omission notes + a snapshot-budget-exceeded turn event (original total, ceiling, omitted count/chars). TreeAndChanged no-baseline/empty-diff falls through the SAME budget path (first turn is never an unlimited full dump). ExcludeFilePatterns (*.min.js/*.min.css/lock files/designer/migration snapshots) drop generated files from the attached dump; MaxDumpedFileChars (50k) replaces oversized files with heading + placeholder. Change-stash: the TreeAndChanged diff is computed at refresh time BEFORE the baseline is overwritten (the old code diffed against a just-captured baseline, so changed-files.txt could never list real changes). UNVERIFIED until live: a real first turn on a large workspace stays under the ceiling with referenced files present, and the second turn shows the changed-files diff.

Directory.Build.props

@@ -1,36 +1,34 @@
 <Project>
-
-    <PropertyGroup>
-        <TargetFramework>net10.0</TargetFramework>
-        <ImplicitUsings>enable</ImplicitUsings>
-        <Nullable>enable</Nullable>
-        <LangVersion>latest</LangVersion>
-        <AnalysisLevel>latest</AnalysisLevel>
-        <AnalysisMode>All</AnalysisMode>
-	    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
-	    <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
-	    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
-	    <InvariantGlobalization>false</InvariantGlobalization>
-	    <NuGetAudit>false</NuGetAudit>
-        <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    </PropertyGroup>
-	<PropertyGroup>
-		<!-- CA1031: boundary methods intentionally convert any exception into an Outcome failure.
+  <PropertyGroup>
+    <TargetFramework>net10.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <LangVersion>latest</LangVersion>
+    <AnalysisLevel>latest</AnalysisLevel>
+    <AnalysisMode>All</AnalysisMode>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <InvariantGlobalization>false</InvariantGlobalization>
+    <NuGetAudit>false</NuGetAudit>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+  </PropertyGroup>
+  <PropertyGroup>
+    <!-- CA1031: boundary methods intentionally convert any exception into an Outcome failure.
 		     CA1040: IService is a deliberate marker interface (DepLens convention).
 		     CA1303: the CLI is not a localized application.
 		     CA1307/CA1308: StringComparison overload suggestions on char comparisons are noise here.
 		     CA1822: stateless runners stay instance methods for injection symmetry.
 		     S3267: "simplify loop" suggestions fight legitimate async loops with early returns.
 		     CA1707, S1135, CA1861: style choices mirrored from the reference repository. -->
-		<NoWarn>$(NoWarn);CA1873;CA2007;CA1031;CA1040;CA1303;CA1307;CA1308;CA1822;S3267;CA1707;S1135;CA1861;CA1056;CA1054;CA2000;CA5394;S1075;S2245</NoWarn>
-	</PropertyGroup>
-    <ItemGroup Condition="'$(MSBuildProjectExtension)' != '.dcproj' and '$(MSBuildProjectName)' != 'ImanSoftware.KeylessAgent.Tests'">
-        <PackageReference Include="SonarAnalyzer.CSharp">
-        <PrivateAssets>all</PrivateAssets>
-        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-        </PackageReference>
-    </ItemGroup>
-
+    <NoWarn>$(NoWarn);CA1873;CA2007;CA1031;CA1040;CA1303;CA1307;CA1308;CA1822;S3267;CA1707;S1135;CA1861;CA1056;CA1054;CA2000;CA5394;S1075;S2245</NoWarn>
+  </PropertyGroup>
+  <ItemGroup Condition="'$(MSBuildProjectExtension)' != '.dcproj' and '$(MSBuildProjectName)' != 'ImanSoftware.KeylessAgent.Tests'">
+    <PackageReference Include="SonarAnalyzer.CSharp">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
   <PropertyGroup>
     <!-- The single source of the application version: Program.cs reads it from the
          assembly and publish.ps1 bumps it here. -->
@@ -45,6 +43,5 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <RepositoryUrl>https://github.com/ImanEstiri/KeylessAgent</RepositoryUrl>
     <PackageReadmeFile Condition="Exists('README.md')">README.md</PackageReadmeFile>
-
   </PropertyGroup>
-</Project>
+</Project>

KeylessAgent.slnx

@@ -1,7 +1,18 @@
 <Solution>
-  <Project Path="src\Core\ImanSoftware.KeylessAgent.Abstractions\ImanSoftware.KeylessAgent.Abstractions.csproj" />
-  <Project Path="src\Core\ImanSoftware.KeylessAgent.Core\ImanSoftware.KeylessAgent.Core.csproj" />
-  <Project Path="src\UI\ImanSoftware.KeylessAgent.Cli\ImanSoftware.KeylessAgent.Cli.csproj" />
-  <Project Path="src\Playground\ImanSoftware.KeylessAgent.Playground\ImanSoftware.KeylessAgent.Playground.csproj" />
-  <Project Path="src\tests\ImanSoftware.KeylessAgent.Tests\ImanSoftware.KeylessAgent.Tests.csproj" />
+  <Folder Name="/src/" />
+  <Folder Name="/src/Core/">
+    <Project Path="src\Core\ImanSoftware.KeylessAgent.Abstractions\ImanSoftware.KeylessAgent.Abstractions.csproj" />
+    <Project Path="src\Core\ImanSoftware.KeylessAgent.Core\ImanSoftware.KeylessAgent.Core.csproj" />
+  </Folder>
+  <Folder Name="/src/Playground/">
+    <Project Path="src\Playground\ImanSoftware.KeylessAgent.Playground\ImanSoftware.KeylessAgent.Playground.csproj" />
+  </Folder>
+  <Folder Name="/src/tests/">
+    <Project Path="src/tests/ImanSoftware.KeylessAgent.Wpf.Tests/ImanSoftware.KeylessAgent.Wpf.Tests.csproj" />
+    <Project Path="src\tests\ImanSoftware.KeylessAgent.Tests\ImanSoftware.KeylessAgent.Tests.csproj" />
+  </Folder>
+  <Folder Name="/src/UI/">
+    <Project Path="src/UI/ImanSoftware.KeylessAgent.Wpf/ImanSoftware.KeylessAgent.Wpf.csproj" />
+    <Project Path="src\UI\ImanSoftware.KeylessAgent.Cli\ImanSoftware.KeylessAgent.Cli.csproj" />
+  </Folder>
 </Solution>