Add translation#25
Conversation
Updated localizable strings for new features and existing entries across both targets, including version adjustments.
- Add proper error handling in DAOs with throws instead of silent failures - Update insert/update methods to support createdAt and isCompleted fields - Fix repository update method to use id instead of entity reference - Make toggleTodoCompleteStatus async to properly persist changes to DB - Improve error logging using SuperLog.e for errors instead of debug level - Add consistent error handling across CoreData and SwiftData paths Changes: - CoreDataTodoDao: Add createdAt and isCompleted to insert/update - SwiftDataTodoDao: Add createdAt and isCompleted to insert/update - ITodoDao: Update interface signatures to throw errors - TodoRepository: Add error handling with fallback to empty arrays - TodoHomeViewModel: Make toggle async and persist to database - ITodoRepository: Update method signature to use id instead of entity
- Remove force unwrap in Encodable.toJSONString() to prevent crashes - Remove @unchecked Sendable from Backend class (not needed) - Use user ID for profile image URLs instead of hardcoded ID - Update localization: "jailbroken-status" to "Jailbroken Status" - Fix trailing newline in Localizable.xcstrings Safety improvements: - Encodable+.swift: Return optional String instead of force unwrapping - Backend.swift: Remove unsafe @unchecked Sendable conformance - Store module: Dynamic profile images based on user ID
Add user-facing error handling with alert dialogs to provide feedback when database operations fail. Key improvements: - Add showErrorAlert property for clean SwiftUI binding - Add errorMessage property to store user-friendly error messages - Fix critical bug: only update local state after successful DB operations - Change add() to reload data from DB instead of appending to local list - Use clearError() method consistently to avoid code duplication - Display error alerts in TodoHomeScreen with native SwiftUI alert - Improve error logging with descriptive messages Error handling added for: - Failed to add todo - Failed to update todo - Failed to toggle todo status This addresses the code review feedback about missing user-facing error handling in TodoHomeViewModel.
- Create MockCertificateStore extension with reusable certificate constants - Move certificate constants from NetworkKitTests to centralized location - Add mock certificate for httpbin.org (Amazon RSA 2048 M02) - Update NetworkKitProdTests with improved test organization - Fix error message assertions to match actual implementation - Add tests for certificate pinning edge cases (no match, empty list) - Improve test documentation for production environment setup
Summary of ChangesHello @ImaginativeShohag, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive localization support across the application's UI by externalizing numerous strings. It also includes a significant overhaul of the networking layer, enhancing its robustness with a new certificate pinning implementation and refined error handling. The Todo module's data persistence and UI logic have been updated for better data management and user feedback. Additionally, new utilities for UI testing have been integrated, and the project's build system configuration has been modernized to accommodate these changes and improve developer experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a wide range of improvements across the project. The primary focus, as indicated by the title, is on localization, and it's great to see hardcoded strings being replaced with localized keys. Beyond that, there are significant and valuable refactorings in the networking layer, the Todo module's data persistence, and the Tuist project structure. These changes enhance security, modularity, and code quality.
My review has identified a few instances of incorrect localization keys, likely due to copy-paste errors, which I've flagged as high-severity issues. I've also included some medium-severity suggestions for improving the new documentation files to ensure they are clear and accurate. Overall, this is a substantial and positive contribution to the codebase.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Mock repository no longer satisfies throws requirement
The new ITodoRepository protocol (Targets/Todo/Sources/Repository/ITodoRepository.swift) now declares func getBy(id:) async throws, but MockTodoRepository still implements func getBy(id:) async -> UITodo.Todo? without throws. In Swift a non‑throwing implementation cannot satisfy a throwing requirement, so this class no longer conforms to the protocol and the project fails to build anywhere the mock is compiled (previews/tests). Update the mock’s signature to include throws (and adjust call sites if needed) so it matches the protocol.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Move project documentation from CLAUDE.md to AGENTS.md for better organization - Update CLAUDE.md to reference AGENTS.md - Refactor ImageVideoCapturer to simplify image handling logic and add nil safety for video URLs - Remove deprecated screenshot() and hideKeyboard() methods from View+ extension - Update copyright year to 2025 in UIApplication+ extension - Fix localization key inconsistencies in AppStorageScreen and SuperToastScreen - Reorganize localization strings in Localizable.xcstrings - Add missing tab item label for blue tab - Improve code formatting and consistency across screens
1 participant
No description provided.