Skip to content

Feature/cs vreader story mode#199

Open
JortGroen wants to merge 7 commits into
devfrom
feature/CSVreaderStoryMode
Open

Feature/cs vreader story mode#199
JortGroen wants to merge 7 commits into
devfrom
feature/CSVreaderStoryMode

Conversation

@JortGroen
Copy link
Copy Markdown
Collaborator

CSV reader now has the ability to switch CSV files during a simulation

@JortGroen
Copy link
Copy Markdown
Collaborator Author

ignore the Resrict PRs check, I had accidentally tried to PR into main again... I changed it but the check stays on failed.

@samrenzag-tud
Copy link
Copy Markdown
Collaborator

Left a comment on one of the files that run the e2e tests.
How does the CSVReader know when to switch to the other file?

@JortGroen JortGroen requested review from Dialectiek and removed request for Eutardigrada October 8, 2025 08:47
@JortGroen
Copy link
Copy Markdown
Collaborator Author

Left a comment on one of the files that run the e2e tests. How does the CSVReader know when to switch to the other file?

By default, it will take the first one. This e2e will be expanded on in the future as it will contain all functionalities in the story mode that we are developing. Then, it will also actively switch.

@Dialectiek
Copy link
Copy Markdown
Contributor

Dialectiek commented Oct 8, 2025

One of the failing tests is the check of pushing to main only from dev, why is that failling? we are trying to PR this feature branch to dev. Did you change the destination afterwards or have we accidentally added this check to dev as well? @JortGroen

NVM I saw the disclaimer

@Dialectiek
Copy link
Copy Markdown
Contributor

Won't bypass & merge until previous pr is resolved since it was opened before this one chronologically and I want to ensure there won't be a conflict.

Comment thread tests/e2e_story.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants