Repository navigation
fix(benchmark): bound HTML report history - #240
Merged
IkarusAILabs merged 2 commits intoOct 18, 2026
Merged
IkarusAILabs merged 2 commits into
IkarusAILabs merged 2 commits into
Conversation
Signed-off-by: Oikantik Basu <140976895+Golden007-prog@users.noreply.github.com>
IkarusAILabs
approved these changes
Oct 18, 2026
IkarusAILabs
left a comment
Owner
There was a problem hiding this comment.
This is a solid follow-up to PR #239 that addresses the DoS concern
IkarusAILabs
added a commit
that referenced
this pull request
Oct 18, 2026
…esentation (#243) - PR #239: Offline HTML authority evidence reports with trend views - PR #240: Hard limit (20) on HTML history with ValueError before render - Added to README.md Community Contributors table - Added to GOOD_FIRST_ISSUES.md Completed Issues table (issue #224) Signed-off-by: Ikarus Career Tech <ikaruscareer@gmail.com>
IkarusAILabs
added a commit
that referenced
this pull request
Oct 18, 2026
…dencies alerts (#244) * docs: credit @Golden007-prog for Authority Evidence Benchmark HTML presentation - PR #239: Offline HTML authority evidence reports with trend views - PR #240: Hard limit (20) on HTML history with ValueError before render - Added to README.md Community Contributors table - Added to GOOD_FIRST_ISSUES.md Completed Issues table (issue #224) Signed-off-by: Ikarus Career Tech <ikaruscareer@gmail.com> * ci: pin CodeQL actions by SHA (v4.39.0) to fix Scorecard Pinned-Dependencies alerts All github/codeql-action steps (init, autobuild, analyze, upload-sarif) now pinned to commit 48870fdd6b42ee6474ec4207209ff87609271a5e (v4.39.0) instead of version tag. This resolves 5 open Scorecard Pinned-Dependencies code scanning alerts. Signed-off-by: Ikarus Career Tech <ikaruscareer@gmail.com> --------- Signed-off-by: Ikarus Career Tech <ikaruscareer@gmail.com>
WintersCoder
pushed a commit
that referenced
this pull request
Oct 25, 2026
…257-#260 (#261) - README and CONTRIBUTING contributor tables: add @therealestbenji (#219), @tyza66 (#257, #258, #260) and @HectorGuerilla (#259); extend @ARAVIND281 with #220. CONTRIBUTING also gains @Golden007-prog (#239, #240), already credited in the README. - CHANGELOG [Unreleased]: "Thanks to" lines on the #257, #258 and #260 entries, plus a new entry for the #259 docs change. - GOOD_FIRST_ISSUES: mark #182 and #196 complete with their contributors; record #197 as in progress. Signed-off-by: Ikarus Career Tech <ikaruscareer@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up on the requested history limit and adversarial-input coverage in the review of #239, which has now merged.
HTML benchmark reports accept at most 20 historical evaluations, preserving their explicit order. Excess history raises
ValueErrorbefore any brief is rendered. The writer renders before opening its destination, so a rejected history neither truncates an existing report nor creates an empty one. The limit is documented as a count of historical briefs, not a byte limit on an individual evaluation.Tests cover the 20/21 boundary, preserving existing or absent output files on rejection, and inert handling of script/style breakouts, SVG event handlers, iframe/image payloads, JavaScript links, and encoded HTML across history labels and metrics. Existing numeric-meter restrictions, Markdown parity, and input immutability are also checked.
How was this tested?
python -m pytest tests/test_authority_canonical.py tests/test_authority_benchmark.py -q: 66 passed.python -m pytest tests/ -q: 1,328 passed, 3 skipped.ruff check safeai/ tests/: passed.git diff --check: passed.The repository-wide
ruff check .additionally reports three existing findings inexamples/crewai_example.pyand two fuzz harnesses; those files are unchanged. The merged main tree was verified identical to the tested parent tree before this follow-up was based on it.Checklist
python -m pytest tests/ -q)ruff check safeai/ tests/)AI-assistance disclosure: implementation and verification assisted by OpenAI Codex.