Fix crash when unmounting volumes#821
Open
yut23 wants to merge 1 commit into
Open
Conversation
|
@mati75 |
|
Tested and segfault on unmounting usb drives or other with a open tab no longer happens, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a use-after-free of
monitor, which gets freed byvfs_dir_finalize():spacefm/src/vfs/vfs-dir.c
Lines 228 to 233 in e6f2918
I'm not sure why the VFSDir gets destroyed at that point, but it was probably some internal GLib change, as usual.
Fixes #819.