Skip to content

fix(content): prevent stale generation supersession #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salim4n merged 2 commits into from
Aug 21, 2026
Merged

fix(content): prevent stale generation supersession #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a816496
fix(content): prevent stale runs from replacing newer assets
salim4n Aug 21, 2026
5ef288d
fix(content): allocate versions from immutable history
salim4n Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion packages/infrastructure/src/content/postgres-content-generation-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,43 @@ export class PostgresContentGenerationRepository implements ContentGenerationRep
if (!brief) throw new Error("CONTENT_BRIEF_CHECKPOINT_MISSING");
const asset = (await tx.select().from(contentAssets).where(and(eq(contentAssets.workspaceId, input.workspaceId), eq(contentAssets.id, run.assetId))).limit(1).for("update"))[0];
if (!asset) throw new Error("CONTENT_ASSET_NOT_FOUND");
const latestVersion = asset.latestVersion > 0
? (await tx.select({ id: contentAssetVersions.id, generationRunId: contentAssetVersions.generationRunId }).from(contentAssetVersions).where(and(
eq(contentAssetVersions.workspaceId, input.workspaceId),
eq(contentAssetVersions.assetId, asset.id),
eq(contentAssetVersions.version, asset.latestVersion),
)).limit(1))[0]
: null;
const latestGeneration = latestVersion
? (await tx.select({ createdAt: contentGenerationRuns.createdAt }).from(contentGenerationRuns).where(and(
eq(contentGenerationRuns.workspaceId, input.workspaceId),
eq(contentGenerationRuns.id, latestVersion.generationRunId),
)).limit(1))[0]
: null;
if (latestVersion && latestGeneration && latestGeneration.createdAt.getTime() > run.createdAt.getTime()) {
await tx.update(contentGenerationRuns).set({
status: "blocked",
stage: "completed",
lastErrorCode: "CONTENT_GENERATION_SUPERSEDED",
lastErrorMessage: "A newer generation already finalized this asset",
completedAt: input.now,
updatedAt: input.now,
}).where(and(eq(contentGenerationRuns.workspaceId, input.workspaceId), eq(contentGenerationRuns.id, run.id)));
await appendEvent(tx, {
workspaceId: input.workspaceId,
userId: null,
runId: run.id,
eventType: "ContentGenerationSuperseded",
changes: { assetId: asset.id, latestVersionId: latestVersion.id },
});
return;
}
const versionId = crypto.randomUUID();
const version = asset.latestVersion + 1;
const maxVersion = (await tx.select({ value: sql<number>`coalesce(max(${contentAssetVersions.version}), 0)` }).from(contentAssetVersions).where(and(
eq(contentAssetVersions.workspaceId, input.workspaceId),
eq(contentAssetVersions.assetId, asset.id),
)))[0]?.value ?? 0;
const version = Number(maxVersion) + 1;
const draft = contentDraftSnapshotSchema.parse(run.draftSnapshot);
const audit = contentEvidenceAuditSchema.parse(run.auditSnapshot);
await tx.insert(contentAssetVersions).values({
Expand Down
25 changes: 25 additions & 0 deletions tests/integration/content-generation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,31 @@ databaseDescribe("CNT-101 durable content generation", () => {
await repository.completeRun({ workspaceId, runId: improved.id, critique, readiness: { ready: true, blockers: [] }, now });
expect((await repository.findAssetByIdea({ workspaceId, ideaId }))?.latestVersion).toBe(2);

const stale = await repository.createGeneration({ workspaceId, userId, assetId: asset!.id, operation: "asset.improve", requestKey: "content:integration:stale", now: new Date(now.getTime() + 2_000) });
await repository.startRun({ workspaceId, runId: stale.id, now });
await repository.saveBrief({ workspaceId, runId: stale.id, brief, now });
await repository.saveDraft({ workspaceId, runId: stale.id, draft: { ...draft, body: `${draft.body} Ancien brouillon.` }, now });
await repository.saveAudit({ workspaceId, runId: stale.id, audit, now });
const newer = await repository.createGeneration({ workspaceId, userId, assetId: asset!.id, operation: "asset.improve", requestKey: "content:integration:newer", now: new Date(now.getTime() + 3_000) });
await repository.startRun({ workspaceId, runId: newer.id, now });
await repository.saveBrief({ workspaceId, runId: newer.id, brief, now });
await repository.saveDraft({ workspaceId, runId: newer.id, draft, now });
await repository.saveAudit({ workspaceId, runId: newer.id, audit, now });
await repository.completeRun({ workspaceId, runId: newer.id, critique, readiness: { ready: true, blockers: [] }, now });
const newestAsset = await repository.findAssetByIdea({ workspaceId, ideaId });
await repository.completeRun({ workspaceId, runId: stale.id, critique, readiness: { ready: false, blockers: ["editorial_blocker"] }, now: new Date(now.getTime() + 4_000) });
expect(await repository.findAssetByIdea({ workspaceId, ideaId })).toMatchObject({ latestVersion: newestAsset?.latestVersion, status: "ready", latest: { id: newestAsset?.latest?.id } });
expect(await repository.findRun({ workspaceId, runId: stale.id })).toMatchObject({ status: "blocked", assetVersionId: null, lastErrorCode: "CONTENT_GENERATION_SUPERSEDED" });

await database.client`update content_assets set latest_version = ${newestAsset!.latestVersion - 1} where workspace_id = ${workspaceId} and id = ${asset!.id}`;
const afterRollback = await repository.createGeneration({ workspaceId, userId, assetId: asset!.id, operation: "asset.improve", requestKey: "content:integration:after-rollback", now: new Date(now.getTime() + 5_000) });
await repository.startRun({ workspaceId, runId: afterRollback.id, now });
await repository.saveBrief({ workspaceId, runId: afterRollback.id, brief, now });
await repository.saveDraft({ workspaceId, runId: afterRollback.id, draft, now });
await repository.saveAudit({ workspaceId, runId: afterRollback.id, audit, now });
await repository.completeRun({ workspaceId, runId: afterRollback.id, critique, readiness: { ready: true, blockers: [] }, now: new Date(now.getTime() + 6_000) });
expect((await repository.findAssetByIdea({ workspaceId, ideaId }))?.latestVersion).toBe(newestAsset!.latestVersion + 1);

const execution = await publicationRepository.claimExecution({ workspaceId, publicationId: scheduled.id, currentAccountId: "linkedin-account-fixture", executionToken: crypto.randomUUID(), now: new Date(now.getTime() + 2_000) });
expect(execution.text).toBe(draft.body);
expect(await publicationRepository.inspectExecution({ workspaceId, publicationId: scheduled.id, now: new Date(now.getTime() + 3_000) })).toBe("unknown");
Expand Down
Loading