feat(localization): Move old samples for localization and add separate sample for the new localization. #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sample for the new localization.
17 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the localization samples to use a new localization API (registerI18n and setCurrentI18n) instead of the legacy approach. The old samples are preserved under a separate "localization-samples-old" directory with a "Legacy" designation, while the main localization sample is updated to demonstrate the new API.
Changes:
- Updated the main localization sample to use the new
registerI18nandsetCurrentI18nAPIs - Moved legacy localization samples to a separate directory with a new route
- Added
provideIgniteIntl()to application configuration - Updated dependencies to use alpha versions that support the new localization API
Reviewed changes
Copilot reviewed 11 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/services/services.routes.ts | Updated imports and added route for legacy localization sample |
| src/app/services/services-routes-data.ts | Added display name for legacy localization route |
| src/app/services/localization-samples/localization-all-resources/localization-all-resources.component.ts | Refactored to use new registerI18n and setCurrentI18n APIs, removed Angular locale registration |
| src/app/services/localization-samples-old/localization-all-resources/localization-all-resources.component.ts | New file preserving the legacy localization implementation |
| src/app/services/localization-samples-old/localization-all-resources/localization-all-resources.component.scss | New file with styles for legacy component |
| src/app/services/localization-samples-old/localization-all-resources/localization-all-resources.component.html | New file with template for legacy component |
| src/app/app.config.ts | Added provideIgniteIntl() provider for new localization system |
| package.json | Updated igniteui-angular packages to alpha versions and added igniteui-i18n-resources dependency |
| live-editing/configs/LocalizationConfigGenerator.ts | Updated to use BaseAppAngularLocaleConfig for legacy samples |
| live-editing/configs/BaseConfig.ts | Added provideIgniteIntl() provider and duplicate HammerModule entry |
| live-editing/configs/BaseConfig-AngularLocale.ts | New config file for legacy localization samples without new provider |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ices/localization-samples/localization-all-resources/localization-all-resources.component.ts
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dkamburov
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.