Drop stale doc references#370
Merged
Merged
Conversation
The function was removed from src/indsnetwork.jl in #356 along with the IndsNetwork-based ITensorNetwork constructor family, but this entry in docs/src/experimental_methods.md was missed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 76.77% 76.77%
=======================================
Files 57 57
Lines 2631 2631
=======================================
Hits 2020 2020
Misses 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tindex!(bpc, ...) `data_graph_type` was an accessor in the pre-#365 DataGraph-based storage layout. After #365 inlined storage into NamedGraph + Dictionary fields, no implementation of `data_graph_type` remains in src/, but the docs still listed it for `AbstractFormNetwork`, `QuadraticFormNetwork`, `AbstractBeliefPropagationCache`, `AbstractTTN` (as a prose label), and `TreeTensorNetwork`. Drop all of those entries. `edge_data_eltype(::Type{<:AbstractIndsNetwork})` was a misnamed reference — the actual function is `DataGraphs.edge_data_type`. Fix the name. `setindex!(bpc, factor, vertex)` is documented for both `AbstractBeliefPropagationCache` and `BeliefPropagationCache`, but neither type has a corresponding method in src/. Drop both entries.
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only cleanup: remove references in
docs/src/experimental_methods.mdanddocs/src/developer_methods.mdto methods that no longer exist in src/.visualize(is::IndsNetwork, args...; kwargs...)— removed fromsrc/indsnetwork.jlin #356 along with theIndsNetwork-basedITensorNetworkconstructor family. The doc entry was missed.data_graph_type— was an accessor for the pre-#365DataGraph-based storage layout. After Add reverse Index map to ITensorNetwork; drop preserve_graph and fix_edges! #365 inlined storage intoNamedGraph + Dictionaryfields, no implementation remains in src/, but the docs still listed it forAbstractFormNetwork,QuadraticFormNetwork,AbstractBeliefPropagationCache,AbstractTTN(as a prose label), andTreeTensorNetwork. Drop all of those entries.edge_data_eltype(::Type{<:AbstractIndsNetwork})— misnamed; the actual function isDataGraphs.edge_data_type. Fix the name.setindex!(bpc, factor, vertex)— documented for bothAbstractBeliefPropagationCacheandBeliefPropagationCache, but neither type has a corresponding method in src/. Drop both entries.No version bump — substantive change accumulates against the existing
0.22.0-DEVprerelease.