Big merge with recent version from Han Uitenbroek#46
Open
tiagopereira wants to merge 132 commits into
Open
Conversation
See docs/changelog and the literature (e.g. Uitenbroek 2001, ApJ, 557, 339) for earlier history.
Eliminated POLARIZATION_FREE option. Convergence now works for STOKES_MODE=FULL_STOKES.
Deprecated. Main Makefile now reads OS and regulates compile options based on that.
Deperecated. Main Makefile new gets OS and makes compile decisions based on that.
Deprecated
Deprecated
lapplied sorted to listdir to make reading of files more deterministic
phi_V and psi_V were not multiplied by the isotopic fraction
Fixed problems with the autoionisation rates
This adds a class for reading, writing and manipulating RH-style model atoms
-- Flux is read into spectrum.flux -- molecules and their densities are read into atmos.molecules -- Hminus number density is read into atmos.Hminus
Notebook with examples of the use of RH analyze python routines
See RH_example.ipynb for corresponding notebook. Unpack with tar xzvf run_examples.tgz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core of RH 1.5D was forked off Han Uitenbroek's RH around 2010. Much has evolved since then, and both codebases evolved. Sometimes innovations from RH 1.5D were backported to RH in different ways but offering the same functionality. Some changes made in RH 1.5D turned out unnecessary and it was best to keep the original way.
This merge joins the two codebases, trying to keep as much of Uitenbroek's codebase with departures only when necessary. For the sake of simplicity, some functionality currently in RH 1.5D has not yet been added back, e.g.:
S_LINEARfrom Jaime de la Cruz RodriguezBecause of different default options (sometimes hardcoded), this code will not give exactly the same result as RH. But it should very close in most cases. However, it has been tested to give the same results between its own
rhf1dandrh15d. Other geometries should work as well, but have not yet been tested.