Expanded output for get_surrogate_values()#42
Merged
Conversation
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Lance-Drane
commented
Jun 7, 2026
vreshniak
approved these changes
Jun 7, 2026
vreshniak
left a comment
vreshniak
left a comment
Contributor
There was a problem hiding this comment.
Everything looks fine to me
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Add hypercube strategy for get_next_point
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Contributor
Author
|
UPDATE: also returning the length of dataset_x in all stateless functions per request. This can sometimes be useful in INTERSECT to handle the inherent asynchronous nature of function calls. |
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
konstpieper
reviewed
Jun 8, 2026
konstpieper
left a comment
konstpieper
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, just have two questions for clarification.
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
also update the provided scripts Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
konstpieper
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want this to be a PR instead of a hotfix develop push because this changes the output structure of
get_surrogate_values(dataclass only).get_surrogate_values()should in theory handle any N-dimensional data structure, and we also don't necessarily want to couple its return value toget_next_pointorget_next_points, so I went ahead and created a custom return class for it.(The CI action is temporary and will be reverted after this MR is approved)
Closes #40