doctor shows CI's pins next to what is installed, and never fails on them - #114
Merged
Conversation
…them K3D_VERSION moves to workflows/shared.ts — it was restated in both k3d-using pipelines, and the pin display only stays honest while there is exactly one place the pin lives. The rendered workflows are byte-identical after the move. doctor reads the pins off that file and prints them beside the local version for k3d and node, plus a line for just itself — which was never presence-checked, you are running it, but whose version can still disagree with the one CI installs. Informational only: a working 5.8.3 against a pinned 5.9.0 is information, and failing a preflight over a patch difference is how a preflight gets ignored — the reasoning the recipe already applied to sops and age. First run on this machine promptly showed two real divergences (k3d v5.8.3 vs v5.9.0, just 1.46.0 vs 1.36.0), neither of which had ever been visible anywhere an operator looks. Closes #63. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017BQGewVRzp9FS1jXn1H6A6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63, in its own words: print the pinned version next to the installed one where a pin exists, without failing.
K3D_VERSIONconsolidates intoworkflows/shared.ts(it was restated in both k3d-using pipelines); the rendered workflows are byte-identical after the move, andjust ci-checkproves it.doctorreads the pins from that one file (pin()is three lines of sed, in the repo's awk-the-artifact tradition) and shows them beside the local k3d and node versions — plus ajustline, which was never presence-checked because you are running it, but whose version can still silently disagree with CI's.First run on this machine immediately surfaced two real divergences nobody had seen:
k3d v5.8.3 (CI pins v5.9.0)andjust 1.46.0 (CI pins 1.36.0).just checkgreen.🤖 Generated with Claude Code
https://claude.ai/code/session_017BQGewVRzp9FS1jXn1H6A6