Wrong variable bounds for storage#107
Open
scrappie1 wants to merge 4 commits into
Open
Conversation
Contributor
|
Please fix the merge conflicts. Also, as you see in the test system, the bounds of the vStInter/IntraRes variables now differ (of course, because we changed them). That means, we need to replace the comparison mps-files with ones. I can show you how to do that. Finally, please also switch to the newest InOutModule main commit, since I just merged some other branches and we should update it here as well :) |
Switch to newest InOutModule
scrappie1
force-pushed
the
feature/storageVariableBounds
branch
from
3538971 to
736db43
Compare
FelixCAAuer
requested changes
Jul 7, 2026
FelixCAAuer
left a comment
FelixCAAuer
left a comment
Contributor
There was a problem hiding this comment.
Thank you :)
Just a few questions to be sure :)
FelixCAAuer
approved these changes
Jul 10, 2026
FelixCAAuer
left a comment
FelixCAAuer
left a comment
Contributor
There was a problem hiding this comment.
Perfect, thank you! Can be merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105