Feature/update py psa reader#33
Open
scrappie1 wants to merge 38 commits into
Open
Conversation
…ity with LEGO database.
… and update PypsaReader to now run with command line arguments
FelixCAAuer
requested changes
Jul 7, 2026
FelixCAAuer
left a comment
FelixCAAuer
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much!
Could you please move all pypsa related files into a sub-folder called PyPSA/ ? (And check if it is still callable and can access all imports correctly and all paths in the description still work. In the outside README.md, then explain what is in the folder and that it has its own README.md file (which you then can call README.md :) ). Thanks! :)
|
|
||
| ## Purpose & limitations | ||
|
|
||
| - This reader only converts PyPSA networks to LEGO input files (EXCEL). It does not return a LEGO CaseStudy object. |
Contributor
There was a problem hiding this comment.
Wouldn't it also be possible to return the CaseStudy object? Please add the option to also receive the object (the constructor of CaseStudy can handle dataframes, so handing over the dataframes which otherwise are handed to the ExcelWriter should work). Otherwise, we can check what is missing :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.