Skip to content

iss #274 add leaf_wetness_sensor and leaf_surface_wetness#315

Open
kersting wants to merge 1 commit into
devfrom
feature/274-add-leaf-wetness
Open

iss #274 add leaf_wetness_sensor and leaf_surface_wetness#315
kersting wants to merge 1 commit into
devfrom
feature/274-add-leaf-wetness

Conversation

@kersting

Copy link
Copy Markdown
Collaborator

Summary

Changes

Test plan

  • Validate that the JSON schema is still valid
  • Validate the demo file against the updated schema using jsonschemavalidator
  • Verify PostgreSQL SQL statements are compatible with the updated schema

@stephenholleran

Copy link
Copy Markdown
Collaborator

Hi @kersting,

Thanks for this, a few questions:

  1. What units do these sensors typically measure and do we have them covered?
  2. I had a suggestion to change leaf_surface_wetness to surface_wetness not that it is wrong but just to capture that we are implying that the surface of the anemometer will be wet. But the sensor mimics a leaf so it is probably good to keep it as is. I suppose if there are other types of sensors that can measure surface wetness then we should consider changing but I don't think there is.
  3. Should we consider adding this measurement to the demo file?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants