Skip to content

iss #259 rename lidar_config to remote_sensing_config#312

Open
kersting wants to merge 1 commit into
dev-v2.0from
feature/259-rename-lidar-config
Open

iss #259 rename lidar_config to remote_sensing_config#312
kersting wants to merge 1 commit into
dev-v2.0from
feature/259-rename-lidar-config

Conversation

@kersting

Copy link
Copy Markdown
Collaborator

Summary

  • Rename lidar_config to remote_sensing_config to reflect that properties like logger_stated_device_datum_plane_height_m and logger_stated_device_orientation_deg apply to all remote sensing devices (lidars and sodars), not just lidars (Issue [SCHEMA] - rename lidar_config to remote_sensing_config #259)
  • This is a breaking change for v2.0.0

Changes

  • schema/iea43_wra_data_model.schema.json: Renamed lidar_config key to remote_sensing_config, updated title and description
  • tools/iea43_wra_data_model_postgresql.sql: Renamed lidar_config table to remote_sensing_config
  • demo_data/floating_lidar_demo_iea43_wra_data_model.json: Updated key name from lidar_config to remote_sensing_config
  • floating_lidar_file_format/floating_lidar_file_format_header.schema.json: Renamed lidar_config key to remote_sensing_config, updated title and description
  • CHANGELOG.md: Added entry under [2.0.0] section referencing issue [SCHEMA] - rename lidar_config to remote_sensing_config #259

Test plan

  • Validate that the JSON schema is still valid
  • Validate the demo file against the updated schema using jsonschemavalidator
  • Verify PostgreSQL SQL statements are compatible with the updated schema
  • Validate the floating lidar file format schema is still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant