Replace deprecated alloc / free + modern repo structure#4
Open
mmyrte wants to merge 5 commits into
Open
Conversation
These had been deprecated since R 3.4.0 https://cran.r-project.org/doc/manuals/r-release/NEWS.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed how this package couldn't be built / installed, and I wanted to reproduce some results with old code that was lying around. Found out that the failure to build, at least on macOS, was due to the use of Calloc/Free that had been deprecated since R 4.2 and finally removed in R4.4. The R_Calloc/R_Free alternatives had been available since 3.4, so there is little chance of this change being very backward-incompatible.
In order to work with regular devtools and friends, I moved the R package onto the toplevel of the repository. It's unclear why
git mvdidn't track these files correctly; I can try to fix this, if you want.