Open
Conversation
- Add explicit data_classification_policy=['public'] parameter to create_dataset() - Removes warning: 'LoadFromDictionary sets data_classification_policy to [proprietary] by default' Signed-off-by: Yoav Katz <katz@il.ibm.com>
- Update all from_pretrained() calls to use 'dtype' instead of 'torch_dtype' - Fixes deprecation warning from transformers library - Changes in HFPipelineBasedInferenceEngine, LlavaInferenceEngine, and HFPeftInferenceEngine Signed-off-by: Yoav Katz <katz@il.ibm.com>
yoavkatz
force-pushed
the
fix-qa-evaluation-data-classification-policy
branch
from
0b9f317 to
3d3b21d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added data_classification_policy=["public"] parameter to create_dataset()
Removes warning: "LoadFromDictionary sets 'data_classification_policy' to ['proprietary'] by default..."
Replaced all torch_dtype parameters with dtype in model initialization calls
Updated in 4 locations across HFPipelineBasedInferenceEngine, LlavaInferenceEngine, and HFPeftInferenceEngine
Removes warning: "torch_dtype is deprecated! Use dtype instead!"
Verification:
Ran examples/qa_evaluation.py successfully with no warnings
All pre-commit checks passed (ruff, ruff-format, detect secrets, codespell, import enforcement)
Changes pushed to remote branch