Skip to content

fix: improve _is_excluded_line #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarstenLeue wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix: improve _is_excluded_line #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions detect_secrets/plugins/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ def default_options(cls):
return {}

def _is_excluded_line(self, line):
# Fast path: skip all regex work when the line cannot possibly carry an
# allowlist comment. 'pragma' appears in every allowlist variant and in
# virtually no ordinary source lines, so this eliminates ~29 M regex
# calls on repositories that have no allowlist comments.
if 'pragma' not in line:
if not self.exclude_lines_regex:
return False
return bool(self.exclude_lines_regex.search(line))
return (
any(
allowlist_regex.search(line)
Expand Down