fix(scoring): validate optional metadata and duplicate queue IDs#3
Draft
ethanolivertroy wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A focused, dependent fix for #2 (
risk-scoring-gaps-1-7). It keeps the scoring model intact while closing two contract gaps found during isolated review:asset_idvalues at collection-assessment time, preventing themigration_work_queuefrom failing with a Rego function-output conflict;regulatory_categoryanddependent_asset_countvalues whenever supplied, so malformed enrichment cannot be silently accepted behind an explicit numeric deadline;Regression coverage
Validation
Executed in a disposable, network-blocked Modal CPU sandbox:
This deliberately targets
risk-scoring-gaps-1-7, rather thanmain, so it can be reviewed and merged as a small follow-up to #2.