Fix string length validation inconsistency between zod and validator #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-rai
changed the title
ramilamparo
approved these changes
Jul 10, 2025
satvik007
approved these changes
Jul 22, 2025
satvik007
merged commit 924b7cd
into
dev/himanshu/fix-schema-generation-embedded-recursive-structs
2 checks passed
satvik007
deleted the
dev/himanshu/fix-discrepancy-go-ts-string-length-validation
branch
satvik007
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Fix schema generation for embedded recursive structs * Fix issue in getStructShape and add corresponding UT * Fix string length validation inconsistency between zod and validator (#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18
Go's validator uses
utf8.RuneCountInString(str), which seems to be equivalent to[...str].lengthin Javascript