-
Notifications
You must be signed in to change notification settings - Fork 0
Configure npm publish on Github releases #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure npm publish on Github releases #42
Conversation
* Publish to npm on creating new Github releases * Properly configure prettier and run it on commit via lint-staged
Summary of ChangesHello @hi-rai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's development and release pipeline by introducing automated npm package publishing tied to GitHub releases. It also establishes a robust code quality gate by integrating Prettier for consistent code formatting and enforcing it via lint-staged during the commit process. These changes aim to improve code maintainability, reduce manual release steps, and ensure a uniform code style. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces prettier for code formatting and lint-staged to automatically format code on pre-commit, which is a great step for maintaining code consistency. The changes correctly set up the new tooling in package.json and the .husky/pre-commit hook. Most of the file modifications are formatting adjustments from running Prettier.
I've added one suggestion in package.json to include eslint-config-prettier. This will prevent potential conflicts between ESLint and Prettier rules, making the setup more robust.
The PR description also mentions publishing to npm on GitHub releases, but the corresponding workflow file is not included in the changes, so I was unable to review that part.
Overall, this is a solid improvement to the development workflow.
|
/gemini review Also include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Prettier for code formatting and lint-staged with Husky to enforce code style on pre-commit. These are excellent additions for maintaining code quality and consistency. The configurations for ESLint, Prettier, and lint-staged are well-implemented.
However, the pull request title and description state that this PR configures npm publishing on GitHub releases. The changes in this PR do not reflect that; they are focused on linting and formatting. Please consider updating the title and description to accurately reflect the content of the pull request.
I have one specific comment regarding the pre-commit hook behavior.
satvik007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hi-rai
This fixes https://github.com/Hypersequent/tms-issues/issues/2143