Skip to content

Conversation

@hi-rai
Copy link
Contributor

@hi-rai hi-rai commented Dec 29, 2025

  • Publish to npm on creating new Github releases
  • Properly configure prettier and run it on commit via lint-staged

This fixes https://github.com/Hypersequent/tms-issues/issues/2143

* Publish to npm on creating new Github releases
* Properly configure prettier and run it on commit via lint-staged
@hi-rai hi-rai self-assigned this Dec 29, 2025
@hi-rai hi-rai changed the title Configure Github releases Configure npm publish on Github releases Dec 29, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @hi-rai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's development and release pipeline by introducing automated npm package publishing tied to GitHub releases. It also establishes a robust code quality gate by integrating Prettier for consistent code formatting and enforcing it via lint-staged during the commit process. These changes aim to improve code maintainability, reduce manual release steps, and ensure a uniform code style.

Highlights

  • Automated npm Publishing: The project is now configured to automatically publish new versions to npm upon the creation of new GitHub releases, streamlining the release process.
  • Code Formatting with Prettier: Prettier has been integrated into the development workflow to enforce consistent code formatting across the codebase.
  • Pre-commit Formatting Enforcement: Lint-staged is now used to automatically run Prettier and ESLint on staged files before each commit, ensuring that all committed code adheres to the defined formatting standards.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/npm.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces prettier for code formatting and lint-staged to automatically format code on pre-commit, which is a great step for maintaining code consistency. The changes correctly set up the new tooling in package.json and the .husky/pre-commit hook. Most of the file modifications are formatting adjustments from running Prettier.

I've added one suggestion in package.json to include eslint-config-prettier. This will prevent potential conflicts between ESLint and Prettier rules, making the setup more robust.

The PR description also mentions publishing to npm on GitHub releases, but the corresponding workflow file is not included in the changes, so I was unable to review that part.

Overall, this is a solid improvement to the development workflow.

@hi-rai
Copy link
Contributor Author

hi-rai commented Dec 29, 2025

/gemini review

Also include .github/workflows/** files in the review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Prettier for code formatting and lint-staged with Husky to enforce code style on pre-commit. These are excellent additions for maintaining code quality and consistency. The configurations for ESLint, Prettier, and lint-staged are well-implemented.

However, the pull request title and description state that this PR configures npm publishing on GitHub releases. The changes in this PR do not reflect that; they are focused on linting and formatting. Please consider updating the title and description to accurately reflect the content of the pull request.

I have one specific comment regarding the pre-commit hook behavior.

Copy link
Collaborator

@satvik007 satvik007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hi-rai

@hi-rai hi-rai merged commit 889793d into main Dec 30, 2025
1 check passed
@hi-rai hi-rai deleted the dev/himanshu/configure-npm-publish-on-github-release branch December 30, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants