Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Ethernet module to align with the new domain-based infrastructure pattern used throughout the codebase. The module introduces two predefined pin configurations (PINSET_H10 and PINSET_H11) to support different hardware revisions and integrates Ethernet as a domain into the ST-LIB framework.
Changes:
- Added NewEthernet.hpp implementing EthernetDomain following the established domain pattern
- Integrated EthernetDomain into the ST-LIB BuildCtx and initialization sequence
- Commented out HAL_ETH_MspInit GPIO and NVIC initialization to avoid conflicts with the new infrastructure
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| Inc/HALAL/Services/Communication/Ethernet/NewEthernet.hpp | New Ethernet domain implementation with pin configurations, initialization logic, and runtime instance management |
| Inc/ST-LIB.hpp | Integration of EthernetDomain into the build context and initialization sequence; minor formatting improvements |
| Inc/HALAL/HALAL.hpp | Added NewEthernet.hpp include and reordered includes alphabetically |
| LWIP/Target/ethernetif.c | Commented out GPIO and NVIC initialization in HAL_ETH_MspInit to delegate to new infrastructure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7504a92 to
d3c8915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ethernet module has been refactored to align with the new infrastructure.
It should be noted that you have two constants in the EthernetDomain declared to help the user using the old and the new design:
This module has been tested in a Nucleo Development Board using this code in
main.cppin a template project:The test consisted of performing a ping to the address
192.168.1.7successfully. It has NOT been tested in a board