Rewrite maifetch in modern C++20#9
Open
Errordog2 wants to merge 3 commits into
Open
Conversation
Author
|
Validation update: the fork CI for this exact head passed successfully.
That run installs |
Author
|
Validation update after expanding the C++20 API wrapper coverage:
The CI run installs |
Author
|
Validation update after tightening the configurable API base URL support:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1
Fixes #1.
This is a modern C++20 rewrite for the maintainer's latest direction in #1 (comment).
What changed:
maifetch_corelibrary plus the CLI entrypoint.MAIFETCH_*env vars and the documentedMAITEA_*aliases.--no-colorfor plain terminals.Validation performed locally:
git diff --checkI could not run the C++ build locally in this Windows environment because
cmake,g++,clang++, andclare not installed here. The PR includes CI withlibcurl4-openssl-devso GitHub can provide the authoritative build/test signal.