Rewrite maifetch in Java 8#6
Open
alejandrorivas-pixel wants to merge 1 commit into
Open
Conversation
13b2578 to
5c0a4e4
Compare
5c0a4e4 to
b84de74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
/claim #1
This follows the latest maintainer direction in the existing PR comments: rewrite maifetch in Java 8 while preserving the current CLI/config behavior and MaiTea API coverage.
Summary:
MAITEA_*env vars plus legacyMAIFETCH_*varsmvn -B teston Java 8mvn packageand a runnable shaded jarValidation:
mvn testmvn packagejava -jar target/maifetch-1.0.0-SNAPSHOT.jar --helpjavap -verbose target/classes/com/github/hutchyben/maifetch/Main.class | rg "major version"->major version: 52git diff --checkPayout details can be coordinated privately after acceptance.