Rewrite maifetch in Rust#2
Open
MAUROCERON wants to merge 4 commits into
Open
Conversation
Author
|
Follow-up: I expanded the Rust rewrite to cover the small MaiTea API wrapper too, not just the CLI path. Added Rust equivalents for profiles, tracks, status, plays/all-plays, scores/all-scores, and pagination helpers, and split the project into a library plus CLI binary. Validation after the update:
|
Owner
|
Actually I changed my mind the bounty to £75 and wanting a rewrite in zig. ensure there's testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
/claim #1
This rewrites maifetch from Go to Rust while preserving the command-line/config behavior and the existing terminal output shape for the GBP 50 bounty issue.
What changed:
Validation run locally on the latest head:
cargo fmt --checkcargo +1.91.1-x86_64-pc-windows-gnu checkcargo +1.91.1-x86_64-pc-windows-gnu clippy -- -D warningsFresh PR-head validation also confirms the combined logo/text output loop uses the fixed
index < *_lines.len()bounds. A local MSVC check was blocked by this Windows environment missinglink.exe;cargo teston GNU/gnullvm was also limited by local Windows linker availability, while GNU type-checking and clippy pass cleanly.No private payout details are included here.