Fix init_index to create shards in audio/ subdirectory#44
Merged
tlebryk merged 3 commits intofeat/shard-from-audiofrom Feb 11, 2026
Merged
Fix init_index to create shards in audio/ subdirectory#44tlebryk merged 3 commits intofeat/shard-from-audiofrom
tlebryk merged 3 commits intofeat/shard-from-audiofrom
Conversation
Co-authored-by: tlebryk <43556997+tlebryk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on shard from audio implementation
Fix init_index to create shards in audio/ subdirectory
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_all_shards()only discovers shards within subdirectories, not at the dataset root. Wheninit_index=True, shards written directly todataset_rootresulted in an empty index.Changes
init_index=True: Ifoutput_diris not already named "audio", automatically write shards tooutput_dir/audio/subdirectoryoutput_diralready ends with "audio", write shards directly there (avoids nestedaudio/audio/)dataset_rootcorrectly: Compute before potential redirection to ensurekey_mapping.jsonandindex.sqlite3are placed at the proper root levelExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.