Make file sorting optional in shard_from_audio_dir for large corpora#42
Closed
Copilot wants to merge 4 commits intofeat/shard-from-audiofrom
Closed
Make file sorting optional in shard_from_audio_dir for large corpora#42Copilot wants to merge 4 commits intofeat/shard-from-audiofrom
Copilot wants to merge 4 commits intofeat/shard-from-audiofrom
Conversation
…orpora Co-authored-by: tlebryk <43556997+tlebryk@users.noreply.github.com>
Co-authored-by: tlebryk <43556997+tlebryk@users.noreply.github.com>
Co-authored-by: tlebryk <43556997+tlebryk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP on addressing feedback for feat/shard from audio
Make file sorting optional in shard_from_audio_dir for large corpora
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses performance feedback from #40:
sorted(input_dir.rglob(...))materializes and sorts all file paths up-front, causing unnecessary memory/time overhead for large audio datasets.Changes
sort_filesparameter (default:False) toshard_from_audio_dirFalse: iterates lazily over files without sorting (memory efficient)True: materializes full file list and sorts (deterministic ordering)test_sort_files_parameterto verify both behaviorsExample
The generator-based approach eliminates the memory spike from loading all paths before processing begins.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.