Skip to content

Stop the delve items popup working on every frame #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyMM22 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop the delve items popup working on every frame #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions Modules/DelveItemsPopup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,21 +753,26 @@ end

RebuildSpellIdMap()

local activeCache, activeCacheAt = {}, 0

function ns:IsDelveConsumableActive(itemID)
SyncDelveConsumableSession()
if delveConsumablesUsed[itemID] then
return true
end
if PlayerHasActiveBuffsForItem(itemID) then
return true
end
if PlayerHasDelveConsumableUseLock(itemID) then
return true
local now = GetTime()
if now - activeCacheAt > 0.5 then
activeCache, activeCacheAt = {}, now
end
if PlayerCarriesUnusableDelveItem(itemID) then
return true
local cached = activeCache[itemID]
if cached ~= nil then
return cached
end
return false
local active = PlayerHasActiveBuffsForItem(itemID)
or PlayerHasDelveConsumableUseLock(itemID)
or PlayerCarriesUnusableDelveItem(itemID)
activeCache[itemID] = active
return active
end

function ns:ShouldAdviseDelveConsumable(itemID)
Expand Down Expand Up @@ -1007,8 +1012,13 @@ local function GetPopupSecureForRow(row)
btn:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
btn:Hide()
end
if btn._mhConfiguredFor == row.itemID then
btn._row = row
return btn
end
btn:RegisterForClicks("AnyUp", "AnyDown")
ApplyPopupSlotSecureAction(btn, row.itemID)
btn._mhConfiguredFor = row.itemID
EnsurePopupSecureHitTexture(btn)
btn._row = row
btn._mhSecureUseSlot = true
Expand Down Expand Up @@ -1629,6 +1639,12 @@ local function EnsurePopupFrame()
end
return
end
self._mhTickElapsed = (self._mhTickElapsed or 0) + elapsed
if self._mhTickElapsed < 0.25 then
return
end
elapsed = self._mhTickElapsed
self._mhTickElapsed = 0
if InCombatLockdown() and IsDelveItemsUiAllowed() then
self._mhCombatStateElapsed = (self._mhCombatStateElapsed or 0) + elapsed
if self._mhCombatStateElapsed >= 0.5 then
Expand Down