Repository navigation
Conversation
A parenthesised path with a space in its filename was linked as the folder prefix. .conf joins the shared link extensions, parentheses bound the whole path, and a hard wrap between filename words keeps the separating space and the clickable cells on each row. Fixes Ark0N#733 Co-authored-by: DDT <1786035110@qq.com>
Owner
Author
|
Superseded by upstream Ark0N#734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Ark0N#733
A parenthesised file path with a space in its filename (
(/mnt/data/Kobo/Kobo eReader.conf), including when that name is hard-wrapped between the words) was linked as the folder prefix/mnt/data/Kobo/Kobo..confis now a link extension, matching the text the guarded attachment routes already serve. Parentheses bound the whole spaced path (absolute, relative,~/, or a bare filename), so the folder prefix and the extension-bearing tail are not linked as fragments. A hard wrap between those filename words keeps the separating space, and the clickable cells stay on the rows that hold the name. Existing URL, folder, and mid-token path joins are unchanged.Tests:
test/spaced-file-path-links.test.ts,test/file-path-link-forms.test.ts, andtest/response-viewer-file-links.test.ts(these failed before the fix and pass after).