This repository was archived by the owner on Apr 2, 2019. It is now read-only.
Respect Leading Zeros in Initial Render Pass#156
Open
Kelderic wants to merge 1 commit intoHubSpot:masterfrom
Kelderic:master
Open
Respect Leading Zeros in Initial Render Pass#156Kelderic wants to merge 1 commit intoHubSpot:masterfrom Kelderic:master
Kelderic wants to merge 1 commit intoHubSpot:masterfrom
Kelderic:master
Conversation
Currently, an element that is initialized while having a textContent of "000", will be shown as "0". This commit takes a snapshop of the initial value, and then uses that snapshot in the initial render pass, rather than converting the string to a number and then back to a string. This respects leading zeros.
|
This is neat, but didn't work for me ... only doing this during the initial rendering pass caused problems after the initial rendering pass. If I have time I might play with this to respect zero fill during every render pass. I think this is a great approach to the zero fill problem -- simply let the value dictate how to zero-fill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, an element that is initialized while having a textContent of
"000", will be shown as "0". This commit takes a snapshop of the initial
value, and then uses that snapshot in the initial render pass, rather
than converting the string to a number and then back to a string. This
respects leading zeros.