This repository was archived by the owner on Apr 2, 2019. It is now read-only.
Fixed: AMD exporting issues#102
Open
dkulichkin wants to merge 1 commit intoHubSpot:masterfrom
dkulichkin:master
Open
Fixed: AMD exporting issues#102dkulichkin wants to merge 1 commit intoHubSpot:masterfrom dkulichkin:master
dkulichkin wants to merge 1 commit intoHubSpot:masterfrom
dkulichkin:master
Conversation
dkulichkin
commented
Aug 14, 2015
dkulichkin
commented
- When built as an npm module by webpack - gets exported by default as an AMD module, which gives error: "Uncaught Error: define cannot be used indirect" - changed commonJS schema to be first in the exporting format order
- Exporting as amd module does not check jquery's presence
- When built by webpack as an npm package - gets exported as an amd module and produces "define could not be used isolated", hence changed export priority to commonjs - Exporting as amd module does not check jquery's presense
|
👍 |
|
Guys, please, can you merge it to the master?? |
Contributor
|
I believe odometer.js is a built file, so this change would need to be made in odometer.coffee. |
|
@dkulichkin any chance you could make this change to .coffee instead? Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.