Repository navigation
fix: concurrency races in WASM init + grammar loading, transaction safety - #77
Merged
Merged
Conversation
…fety - ensureInit: promise-as-lock pattern prevents concurrent WASM double-init - getLanguage: promise-as-lock prevents duplicate grammar loading for same language - SqliteSyncStorage.transaction: protected ROLLBACK in catch to handle closed connections - persistMerkleState: removed unnecessary read-back of just-written hashes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 issues found during code review of Phase 2 Steps 1+2.
Fixes
ensureInitrace — concurrent calls double-initialize WASMgetLanguagerace — concurrent callers load same grammar twicelanguageLoadingMap tracks in-flight loadsSqliteSyncStorage.transaction— ROLLBACK fails if DB closedpersistMerkleState— unnecessary read-back of just-written hashesfileHashMapfiltered bysuccessfulFilesinstead of N storage readsTest plan
pnpm typecheckpassespnpm format:checkpasses