FIX: Upgrate Next to prevent vulnerabilities from react#27
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR claims to upgrade Next.js to prevent React vulnerabilities, but the actual changes involve significant modifications to the Prisma database configuration, schema generator settings, and database adapter. The PR title contains a typo ("Upgrate" instead of "Upgrade") and doesn't accurately reflect the changes made.
Key Changes:
- Switched database adapter from PrismaLibSQL to PrismaBetterSqlite3 (with incompatible client configuration)
- Changed Prisma client import to use a custom generated path instead of standard @prisma/client
- Modified Prisma schema generator from "prisma-client-js" to "prisma-client"
- Added LOCAL_DATABASE_URL environment variable
- Minor UI styling adjustment (added py-2 to header)
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/db.ts | Changed Prisma import path and database adapter, but adapter and client are incompatible |
| src/env.js | Added LOCAL_DATABASE_URL environment variable that isn't used in runtime code |
| src/app/_components/Header/Header.tsx | Added vertical padding to header component |
| prisma/schema.prisma | Changed generator provider to non-standard value and removed datasource URL |
| prisma/prisma/* | Generated Prisma client files (autogenerated, should not be committed) |
| prisma.config.ts | New Prisma configuration file using LOCAL_DATABASE_URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@HpatricioH I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@HpatricioH I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you. |
Acknowledge PR title feedback - no changes needed
Confirm Prisma 7.x datasource configuration is valid without url field
|
@HpatricioH I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@HpatricioH I've opened a new pull request, #31, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@HpatricioH I've opened a new pull request, #32, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@HpatricioH I've opened a new pull request, #33, to work on those changes. Once the pull request is ready, I'll request review from you. |
No changes needed - keep custom Prisma import path
Address review feedback on Next upgrade PR
Address feedback on Next upgrade PR - no changes needed
Address feedback on unused import in generated Prisma types
Fixes Issue
Changes Proposed
Checklist (Check all the applicable boxes)
Screenshots