fix(plugins): step VST3 stepped params by 1/stepCount instead of 1 (#49) - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
VST3 params with
stepCount > 0showed only 0/1: VST3 ranges are normalised 0..1, but the slider usedstep = 1for stepped params.stepped: boolis replaced bystep: f64(VST3:1 / stepCount, CLAP/AU: 1, continuous: 0).Why is this the right approach?
Only the backend knows the step count. Converting VST3 params to plain units instead would touch every write path.
Checklist
bun run checkpassescargo check --manifest-path src-tauri/Cargo.tomlpassesbun run formatleaves the tree cleanDspWorker::runPlatform coverage
au_host.rs(macOS only): field rename, behaviour unchanged.Related