Skip to content

fix: preserve persistent lab grant lookup errors - #44

Merged
Horcag merged 2 commits into
perf/vm-operation-throughputfrom
fix/persistent-grant-validation-errors
Oct 26, 2026
Merged

Horcag merged 2 commits into
perf/vm-operation-throughputfrom
fix/persistent-grant-validation-errors

Conversation

@Horcag

@Horcag Horcag commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

A provider or enrollment lookup failure while revalidating a matching persistent VM grant could be discarded and later appear as a generic approval_required denial. Preserve the lookup cause and block dispatch; the same stored grant remains usable after recovery. Invalid, revoked, inactive, foreign, and replaced-enrollment grants remain excluded, with the existing grant lease and enrollment fence intact.

The test-only retirement fixture now has a 90-second budget for PowerShell startup and compilation. A private temporary stage file adds bounded stage, elapsed-time and ctx.Err() diagnostics while preserving CombinedOutput, strict JSON checks and malformed-frame sentinels. The original Windows CI failure recorded 30.02 seconds and exit 1 without measuring the stalled stage. A standalone cold-process baseline with the original 30-second limit and the instrumented candidate both passed the exact native case without skips on Windows LTSC with PowerShell 7.6.9; the original CI stall was not reproduced there.

This is stacked on #36 (perf/vm-operation-throughput).

Validation:

  • 20 named production-path outcomes and nine focused loader outcomes passed locally. Full normal and race suites passed; coverage policy passed at 86.0%; lint, shell, workflow, vulnerability, secret and documentation checks passed.
  • Normal repository commit and pre-push hooks passed without bypasses. Independent code/security and architecture reviews found no blocking issues in the production fix; the test-only follow-up was reviewed separately.
  • After a daemon restart with the production fix, MCP prepare, put, get, exec and remove-owned passed without an explicit approval ID. A 122-byte binary round trip matched exactly, and the probe artifact was removed.

@Horcag
Horcag merged commit c7b9e74 into perf/vm-operation-throughput Oct 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant