Skip to content

fix(approval): preserve authority and causal lifecycle timestamps - #42

Merged
Horcag merged 1 commit into
perf/vm-operation-throughputfrom
fix/approval-authority-consistency
Oct 25, 2026
Merged

Horcag merged 1 commit into
perf/vm-operation-throughputfrom
fix/approval-authority-consistency

Conversation

@Horcag

@Horcag Horcag commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Guest approval issuance failed when the live credential provider returned broader permissions than the requested beneficiary. Backward wall-clock steps could also reject freshly derived lab approvals or corrupt persistent SSH lifecycle timestamps, producing intermittent internal errors.

Preserve requested authority while binding configuration generation to the full live principal. Apply a causal time floor only to locally derived lab admissions, keep fresh expiry checks at consumption, and reject inactive consumption before persistence. SSH lifecycle observations and crash reconciliation retain causal timestamps independently of authorization clocks. Known guest approval failures keep their bounded categories instead of falling through to HTTP 500.

Validation: real-provider HTTP issuance and payload execution; clock rollback, future approval, expiry, cancellation, revocation, retry and persistent-session regressions; independent code/security and architecture reviews. Full make quality passed, including race, coverage, vulnerability, secret and documentation checks. Mandatory pre-commit and pre-push hooks also passed. CI results are required before merge.

@Horcag
Horcag merged commit d9a788b into perf/vm-operation-throughput Oct 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant