Repository navigation
fix(tools): route file uploads to whole-file binary streaming - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents can send local file contents through repeated terminal writes, paying command, approval and receipt overhead for each piece. Direct file uploads to the existing whole-file binary
guest_putpath, and local PowerShell scripts toguest_exec, in MCP descriptions, source schema help, CLI session help and documentation. Runtime behavior and authorization are unchanged.Validation: schema snapshot,
make quality, full unit/race tests, coverage (85.9%), and independent code/security and architecture review. Live validation of the existing installed transport uploaded 64 MiB in 4.95 seconds and 1 GiB in 40.93 seconds of daemon operation time (48.84 seconds for the complete MCP call); the 64 MiB download matched SHA-256, and both guest fixtures were removed with observed absence. These are measurements of the existing binary path, not a throughput change introduced by this description-only patch.Updated client binaries passed a real stdio
tools/listsmoke and CLI help readback. The running daemon and existing sessions were preserved.