Repository navigation
fix: persist enrolled VM authority and clarify guest failures - #39
Merged
Horcag merged 4 commits intoOct 21, 2026
Merged
Conversation
Raise the Go minimum to1.26.10 to address GO-2026-6809 in the standard library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner-authorized disposable VM still required a separate one-use approval for every guest or terminal action. Invalid guest requests were also wrapped as uncertain failures and surfaced as generic internal errors, obscuring whether execution had started.
Add an opt-in persistent grant for the exact enrolled VM and beneficiary, covering guest operations, terminal sessions, console/desktop, VM start/stop and checkpoint create/restore until revoked. Retain operation classification, enrollment fencing, actor scopes, deadlines, idempotency and receipts; derive exact approvals from the protected grant. Enrollment replacement or revocation invalidates the authority. Existing bounded grants keep their behavior.
Validate each guest operation at CLI/MCP entry, advertise operation-specific schemas, and propagate redacted typed failures while preserving genuine uncertain outcomes. Negotiate response extensions so existing strict MCP clients continue working after a daemon upgrade. Raise the Go minimum to 1.26.10 for GO-2026-6809.
Validation: full unit and race suites, lint, coverage policy, static/security/documentation checks; independent security and architecture reviews. Installed disposable Windows VM acceptance passed: guest prepare, binary file roundtrip, script execution with administrator privileges, SSH command/output/lifecycle, native desktop input, owned artifact removal and worker retirement. Both persistent grants remained active after daemon restart; pre-existing strict MCP clients also passed validation and desktop discovery checks.