Resolve cross-platform linting, export notification utilities, and add Node 16 fetch compatibility#53
Open
ayushedith wants to merge 3 commits intoHookflo:mainfrom
Open
Resolve cross-platform linting, export notification utilities, and add Node 16 fetch compatibility#53ayushedith wants to merge 3 commits intoHookflo:mainfrom
ayushedith wants to merge 3 commits intoHookflo:mainfrom
Conversation
fnode 16 fetch compatibility, quoting in npm scripts, and export …
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several developer experience (DX) papercuts, cross-platform compatibility issues, and runtime crashes found during a routine repository audit.
🐛 Bug Fixes & Improvements
fetchFallback: Replaced the nativefetchcall in src/notifications/send-alert.ts with a dynamic fallback tonode-fetch. Since theenginesdirective in package.json supports Node>=16.0.0, the pure nativefetch(which is only globally available in Node 18+) was causing runtime ReferenceErrors in older environments."lint:fix"script in package.json to use escaped double-quotes ("src/**/*.ts") instead of single-quotes. Single quotes crashcmd.exeon Windows when running npm scripts.lf(Line Feed) end of lines. This resolves over 5,000 linting errors that occur when cloning the repository on Windows machines (wheregitdefaults to CRLF).Testing Performed
npm run prepare(tsc build).npm run testagainst all webhook configurations.npm run lintnow returns cleanly (0 errors) on both Unix and Windows setups.