The server handles all clients and individually #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issues
What’s Changed
Refactored server to maintain persistent client connections list
Added proper disconnect detection and cleanup
Improved error handling for network operations
Why
Problem: Ghost clients
The original server didn't track connected clients. When a client disconnected, the server would still try to send messages to 4 clients instead of 3, but wouldn't detect the failure. This led to silent errors and poor connection management.
Notes for Reviewers
Server now uses Arc<Mutex<Vec>> to maintain shared client list across threads
Checklist
Tests pass locally
Verified server correctly tracks client count through connect/disconnect cycles
Tested with multiple simultaneous clients